From d3f2d4bd0d34116e36fd6a333c2114fab99cc9c8 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 29 Oct 2024 17:47:32 +0100
Subject: [PATCH 01/16] chore(route): Remove a TODO

---
 appinfo/routes.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/appinfo/routes.php b/appinfo/routes.php
index 755947410..31a6fae5a 100644
--- a/appinfo/routes.php
+++ b/appinfo/routes.php
@@ -55,7 +55,6 @@
 		],
 		[
 			'name' => 'workspace#createWorkspace',
-			// TODO move this route to /api/spaces
 			'url' => '/spaces',
 			'verb' => 'POST'
 		],

From 34967e257fda47fa615239fa056cab26aa0a8e63 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 29 Oct 2024 17:49:06 +0100
Subject: [PATCH 02/16] refactor: Creating a groupfolder on the back-end side

---
 lib/Controller/WorkspaceController.php | 58 +++++---------------------
 src/LeftSidebar.vue                    | 21 ++--------
 src/services/groupfoldersService.js    |  2 +
 src/services/spaceService.js           |  3 +-
 4 files changed, 18 insertions(+), 66 deletions(-)

diff --git a/lib/Controller/WorkspaceController.php b/lib/Controller/WorkspaceController.php
index f92d2946c..961809b82 100644
--- a/lib/Controller/WorkspaceController.php
+++ b/lib/Controller/WorkspaceController.php
@@ -41,6 +41,7 @@
 use OCA\Workspace\Service\UserService;
 use OCA\Workspace\Service\Workspace\WorkspaceCheckService;
 use OCA\Workspace\Service\WorkspaceService;
+use OCA\Workspace\Space\SpaceManager;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\JSONResponse;
@@ -64,6 +65,7 @@ public function __construct(
 		private WorkspaceService $workspaceService,
 		private UserGroup $userGroup,
 		private WorkspaceManagerGroup $workspaceManagerGroup,
+		private SpaceManager $spaceManager,
 		public $AppName
 	) {
 		parent::__construct($AppName, $request);
@@ -82,56 +84,18 @@ private function deleteBlankSpaceName(string $spaceName): string {
 	 * @NoAdminRequired
 	 * @GeneralManagerRequired
 	 * @param string $spaceName
-	 * @param int $folderId
-	 * @throws BadRequestException
-	 * @throws CreateWorkspaceException
-	 * @throws CreateGroupException
 	 */
-	public function createWorkspace(string $spaceName,
-		int $folderId): JSONResponse {
-		if ($spaceName === false ||
-			$spaceName === null ||
-			$spaceName === ''
-		) {
-			throw new BadRequestException('spaceName must be provided');
-		}
-
-		if ($this->workspaceCheck->containSpecialChar($spaceName)) {
-			throw new BadRequestException('Your Workspace name must not contain the following characters: ' . implode(' ', str_split(WorkspaceCheckService::CHARACTERS_SPECIAL)));
-		}
-		
-		if ($this->workspaceCheck->isExist($spaceName)) {
-			throw new WorkspaceNameExistException("The $spaceName space name already exist", Http::STATUS_CONFLICT);
-		}
+	public function createWorkspace(string $spaceName): JSONResponse {
 
-		$spaceName = $this->deleteBlankSpaceName($spaceName);
+		$workspace = $this->spaceManager->create($spaceName);
 
-		$space = new Space();
-		$space->setSpaceName($spaceName);
-		$space->setGroupfolderId($folderId);
-		$space->setColorCode('#' . substr(md5(mt_rand()), 0, 6)); // mt_rand() (MT - Mersenne Twister) is taller efficient than rand() function.
-		$this->spaceMapper->insert($space);
-
-		if (is_null($space)) {
-			throw new CreateWorkspaceException('Error to create a space.', Http::STATUS_CONFLICT);
-		}
-
-		// #2 create groups
-		$newSpaceManagerGroup = $this->workspaceManagerGroup->create($space);
-		$newSpaceUsersGroup = $this->userGroup->create($space);
-
-		// #3 Returns result
-		return new JSONResponse([
-			'name' => $space->getSpaceName(),
-			'id_space' => $space->getId(),
-			'folder_id' => $space->getGroupfolderId(),
-			'color' => $space->getColorCode(),
-			'groups' => GroupFormatter::formatGroups([
-				$newSpaceManagerGroup,
-				$newSpaceUsersGroup
-			]),
-			'statuscode' => Http::STATUS_CREATED,
-		]);
+		return new JSONResponse(
+				array_merge(
+					$workspace,
+					[ 'statuscode' => Http::STATUS_CREATED ]
+				)
+			)
+		;
 	}
 
 	/**
diff --git a/src/LeftSidebar.vue b/src/LeftSidebar.vue
index e05fd1c52..22e1201cc 100644
--- a/src/LeftSidebar.vue
+++ b/src/LeftSidebar.vue
@@ -56,8 +56,8 @@
 </template>
 
 <script>
-import { createGroupfolder, checkGroupfolderNameExist, enableAcl, addGroupToGroupfolder, addGroupToManageACLForGroupfolder } from './services/groupfoldersService.js'
-import { createSpace, deleteBlankSpacename, isSpaceManagers, isSpaceUsers } from './services/spaceService.js'
+import { createGroupfolder, checkGroupfolderNameExist } from './services/groupfoldersService.js'
+import { createSpace, deleteBlankSpacename } from './services/spaceService.js'
 import { PATTERN_CHECK_NOTHING_SPECIAL_CHARACTER } from './constants.js'
 import BadCreateError from './Errors/BadCreateError.js'
 import NcAppNavigation from '@nextcloud/vue/dist/Components/NcAppNavigation.js'
@@ -94,27 +94,14 @@ export default {
 
 			await checkGroupfolderNameExist(name)
 
-			const groupfolderId = await createGroupfolder(name)
-
-			await enableAcl(groupfolderId.data.id)
-
-			const workspace = await createSpace(name, groupfolderId.data.id)
-
-			const GROUPS_WORKSPACE = Object.keys(workspace.groups)
-			const workspaceManagerGid = GROUPS_WORKSPACE.find(isSpaceManagers)
-			const workspaceUserGid = GROUPS_WORKSPACE.find(isSpaceUsers)
-
-			await addGroupToGroupfolder(workspace.folder_id, workspaceManagerGid)
-			await addGroupToGroupfolder(workspace.folder_id, workspaceUserGid)
-
-			await addGroupToManageACLForGroupfolder(workspace.folder_id, workspaceManagerGid)
+      const workspace = await createSpace(name)
 
 			this.$store.commit('addSpace', {
 				color: workspace.color,
 				groups: workspace.groups,
 				isOpen: false,
 				id: workspace.id_space,
-				groupfolderId: groupfolderId.data.id,
+				groupfolderId: workspace.folder_id,
 				name,
 				quota: t('workspace', 'unlimited'),
 				users: {},
diff --git a/src/services/groupfoldersService.js b/src/services/groupfoldersService.js
index 8745be773..cd31909d4 100644
--- a/src/services/groupfoldersService.js
+++ b/src/services/groupfoldersService.js
@@ -237,6 +237,8 @@ export function removeGroupToManageACLForGroupfolder(folderId, gid) {
  * @param {string} spaceName it's the name space to create
  * @return {Promise}
  * @throws {CreateGroupfolderError}
+ * @deprecated
+ * @use createSpace from spaceService
  */
 export function createGroupfolder(spaceName) {
 	return axios.post(generateUrl('/apps/groupfolders/folders'),
diff --git a/src/services/spaceService.js b/src/services/spaceService.js
index f7495137c..736ee2994 100644
--- a/src/services/spaceService.js
+++ b/src/services/spaceService.js
@@ -34,11 +34,10 @@ import AddGroupToGroupfolderError from '../Errors/Groupfolders/AddGroupToGroupfo
 	* @param {object} vueInstance it's an instance of vue
 	* @return {object}
 	*/
-export function createSpace(spaceName, folderId, vueInstance = undefined) {
+export function createSpace(spaceName, vueInstance = undefined) {
 	const result = axios.post(generateUrl('/apps/workspace/spaces'),
 		{
 			spaceName,
-			folderId,
 		})
 		.then(resp => {
 			if (typeof (resp.data) !== 'object') {

From 388746f958fc1cb07f7a67e6955e155511db0736 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Thu, 31 Oct 2024 18:21:49 +0100
Subject: [PATCH 03/16] feature: Respond from backend when workspace already
 exists

---
 lib/Exceptions/AbstractNotification.php        | 15 +++++++++++++++
 lib/Exceptions/WorkspaceNameExistException.php |  8 +++++---
 lib/Middleware/IsGeneralManagerMiddleware.php  | 15 +++++++++++++++
 lib/Middleware/IsSpaceAdminMiddleware.php      | 17 +++++++++++++++--
 lib/Space/SpaceManager.php                     |  5 ++++-
 src/LeftSidebar.vue                            |  5 +----
 src/services/spaceService.js                   |  9 ++++++---
 7 files changed, 61 insertions(+), 13 deletions(-)
 create mode 100644 lib/Exceptions/AbstractNotification.php

diff --git a/lib/Exceptions/AbstractNotification.php b/lib/Exceptions/AbstractNotification.php
new file mode 100644
index 000000000..8a2f501a4
--- /dev/null
+++ b/lib/Exceptions/AbstractNotification.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace OCA\Workspace\Exceptions;
+
+abstract class AbstractNotification extends \Exception
+{
+    public function __construct(protected string $title = 'Error', string $message, int $code)
+    {
+        parent::__construct($message, $code);
+    }
+
+    public function getTitle(): string {
+        return $this->title;
+    }
+}
diff --git a/lib/Exceptions/WorkspaceNameExistException.php b/lib/Exceptions/WorkspaceNameExistException.php
index b56ad93f7..09708fc8c 100644
--- a/lib/Exceptions/WorkspaceNameExistException.php
+++ b/lib/Exceptions/WorkspaceNameExistException.php
@@ -24,8 +24,10 @@
 
 namespace OCA\Workspace\Exceptions;
 
-class WorkspaceNameExistException extends \Exception {
-	public function __construct($message, $code = 0) {
-		parent::__construct($message, $code);
+use OCP\AppFramework\Http;
+
+class WorkspaceNameExistException extends AbstractNotification {
+	public function __construct($title, $message, $code = Http::STATUS_CONFLICT) {
+		parent::__construct($title, $message, $code);
 	}
 }
diff --git a/lib/Middleware/IsGeneralManagerMiddleware.php b/lib/Middleware/IsGeneralManagerMiddleware.php
index 346899770..dbf73d075 100644
--- a/lib/Middleware/IsGeneralManagerMiddleware.php
+++ b/lib/Middleware/IsGeneralManagerMiddleware.php
@@ -26,6 +26,7 @@
 namespace OCA\Workspace\Middleware;
 
 use Exception;
+use OCA\Workspace\Exceptions\AbstractNotification;
 use OCA\Workspace\Middleware\Exceptions\AccessDeniedException;
 use OCA\Workspace\Service\UserService;
 use OCP\AppFramework\Http;
@@ -59,5 +60,19 @@ public function afterException($controller, $methodName, Exception $exception):
 				'msg' => 'You are not allowed to perform this action'
 			], Http::STATUS_FORBIDDEN);
 		}
+
+        if ($exception instanceof AbstractNotification) {
+            return new JSONResponse([
+                'title' => $exception->getTitle(),
+                'statuscode' => $exception->getCode(),
+                'message' => $exception->getMessage()
+            ], $exception->getCode());
+        }
+
+        return new JSONResponse([
+            'statuscode' => $exception->getCode(),
+            'message' => $exception->getMessage(),
+            'trace' => $exception->getTrace()
+        ], $exception->getCode());
 	}
 }
diff --git a/lib/Middleware/IsSpaceAdminMiddleware.php b/lib/Middleware/IsSpaceAdminMiddleware.php
index 269a04068..7168e5bad 100644
--- a/lib/Middleware/IsSpaceAdminMiddleware.php
+++ b/lib/Middleware/IsSpaceAdminMiddleware.php
@@ -25,6 +25,7 @@
 
 namespace OCA\Workspace\Middleware;
 
+use OCA\Workspace\Exceptions\AbstractNotification;
 use OCA\Workspace\Middleware\Exceptions\AccessDeniedException;
 use OCA\Workspace\Service\SpaceService;
 use OCA\Workspace\Service\UserService;
@@ -61,6 +62,18 @@ public function afterException($controller, $methodName, \Exception $exception):
 			], Http::STATUS_FORBIDDEN);
 		}
 
-		return new JSONResponse([]);
-	}
+        if ($exception instanceof AbstractNotification) {
+            return new JSONResponse([
+                'title' => $exception->getTitle(),
+                'statuscode' => $exception->getCode(),
+                'message' => $exception->getMessage()
+            ], $exception->getCode());
+        }
+
+        return new JSONResponse([
+            'statuscode' => $exception->getCode(),
+            'message' => $exception->getMessage(),
+            'trace' => $exception->getTrace()
+        ], $exception->getCode());
+    }
 }
diff --git a/lib/Space/SpaceManager.php b/lib/Space/SpaceManager.php
index fda7d4473..4e6b68c2f 100644
--- a/lib/Space/SpaceManager.php
+++ b/lib/Space/SpaceManager.php
@@ -61,7 +61,10 @@ public function create(string $spacename): array {
 		}
 		
 		if ($this->workspaceCheck->isExist($spacename)) {
-			throw new WorkspaceNameExistException("The $spacename space name already exist", Http::STATUS_CONFLICT);
+			throw new WorkspaceNameExistException(
+                title: 'Error - Duplicate space name',
+                message: "This space or groupfolder already exist. Please, input another space.\nIf \"toto\" space exist, you cannot create the \"tOTo\" space.\nMake sure you the groupfolder doesn't exist."
+            );
 		}
 
 		$spacename = $this->deleteBlankSpaceName($spacename);
diff --git a/src/LeftSidebar.vue b/src/LeftSidebar.vue
index 22e1201cc..d2aae1ec6 100644
--- a/src/LeftSidebar.vue
+++ b/src/LeftSidebar.vue
@@ -81,7 +81,6 @@ export default {
 				showNotificationError('Error', 'Please specify a name.', 3000)
 				return
 			}
-			name = deleteBlankSpacename(name)
 
 			const REGEX_CHECK_NOTHING_SPECIAL_CHARACTER = new RegExp(PATTERN_CHECK_NOTHING_SPECIAL_CHARACTER)
 
@@ -92,9 +91,7 @@ export default {
 				)
 			}
 
-			await checkGroupfolderNameExist(name)
-
-      const workspace = await createSpace(name)
+      const workspace = await createSpace(name, this)
 
 			this.$store.commit('addSpace', {
 				color: workspace.color,
diff --git a/src/services/spaceService.js b/src/services/spaceService.js
index 736ee2994..de043b2ba 100644
--- a/src/services/spaceService.js
+++ b/src/services/spaceService.js
@@ -47,9 +47,12 @@ export function createSpace(spaceName, vueInstance = undefined) {
 			return resp.data
 		})
 		.catch(error => {
-			if (typeof (vueInstance) !== 'undefined') {
-				showNotificationError('Error to create a workspace', error.message, 5000)
-			}
+			if ('response' in error && 'data' in error.response) {
+        showNotificationError(error.response.data.title, error.response.data.message, 5000)
+			} else {
+        showNotificationError('Error to create a workspace', error.message, 5000)
+      }
+
 			throw new BadCreateError(error)
 		})
 	return result

From 0ed9ce5c4115e159a7295d1f40085b2624d8ab51 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Mon, 4 Nov 2024 10:53:57 +0100
Subject: [PATCH 04/16] chore(service): Stamp @deprecated on groupfolder
 functions

---
 src/services/groupfoldersService.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/services/groupfoldersService.js b/src/services/groupfoldersService.js
index cd31909d4..ab18a44bf 100644
--- a/src/services/groupfoldersService.js
+++ b/src/services/groupfoldersService.js
@@ -109,6 +109,8 @@ export function formatUsers(space) {
  * @param {string} spaceName it's the name of space to check
  * @return {boolean}
  * @throws {CheckGroupfolderNameExistError}
+ * @deprecated
+ * @use createSpace from spaceService
  */
 export async function checkGroupfolderNameExist(spaceName) {
 	const duplicateExists = await getAll()
@@ -137,6 +139,8 @@ export async function checkGroupfolderNameExist(spaceName) {
  * @param {number} folderId from a groupfolder
  * @return {Promise}
  * @throws {EnableAclGroupfolderError}
+ * @deprecated
+ * @use createSpace from spaceService
  */
 export function enableAcl(folderId) {
 	return axios.post(generateUrl(`/apps/groupfolders/folders/${folderId}/acl`),
@@ -162,6 +166,8 @@ export function enableAcl(folderId) {
  * @param {string} gid it's an id (string format) of a group
  * @return {Promise}
  * @throws {AddGroupToGroupfolderError}
+ * @deprecated
+ * @use createSpace from spaceService
  */
 export function addGroupToGroupfolder(folderId, gid) {
 	return axios.post(generateUrl(`/apps/groupfolders/folders/${folderId}/groups`),
@@ -186,6 +192,8 @@ export function addGroupToGroupfolder(folderId, gid) {
  * @param {string} gid it's an id (string format) of a group
  * @return {Promise}
  * @throws {AddGroupToManageACLForGroupfolderError}
+ * @deprecated
+ * @use createSpace from spaceService
  */
 export function addGroupToManageACLForGroupfolder(folderId, gid) {
 	return axios.post(generateUrl(`/apps/groupfolders/folders/${folderId}/manageACL`),

From b7b70ee9a18cfe6f2531bffe876c15055e6b5c8e Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Mon, 4 Nov 2024 11:05:24 +0100
Subject: [PATCH 05/16] chore(vue): Remove functions unused and indented with
 tabs

---
 src/LeftSidebar.vue          | 5 ++---
 src/services/spaceService.js | 6 +++---
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/LeftSidebar.vue b/src/LeftSidebar.vue
index d2aae1ec6..575925169 100644
--- a/src/LeftSidebar.vue
+++ b/src/LeftSidebar.vue
@@ -56,8 +56,7 @@
 </template>
 
 <script>
-import { createGroupfolder, checkGroupfolderNameExist } from './services/groupfoldersService.js'
-import { createSpace, deleteBlankSpacename } from './services/spaceService.js'
+import { createSpace } from './services/spaceService.js'
 import { PATTERN_CHECK_NOTHING_SPECIAL_CHARACTER } from './constants.js'
 import BadCreateError from './Errors/BadCreateError.js'
 import NcAppNavigation from '@nextcloud/vue/dist/Components/NcAppNavigation.js'
@@ -91,7 +90,7 @@ export default {
 				)
 			}
 
-      const workspace = await createSpace(name, this)
+			const workspace = await createSpace(name, this)
 
 			this.$store.commit('addSpace', {
 				color: workspace.color,
diff --git a/src/services/spaceService.js b/src/services/spaceService.js
index de043b2ba..6473d6f19 100644
--- a/src/services/spaceService.js
+++ b/src/services/spaceService.js
@@ -48,10 +48,10 @@ export function createSpace(spaceName, vueInstance = undefined) {
 		})
 		.catch(error => {
 			if ('response' in error && 'data' in error.response) {
-        showNotificationError(error.response.data.title, error.response.data.message, 5000)
+				showNotificationError(error.response.data.title, error.response.data.message, 5000)
 			} else {
-        showNotificationError('Error to create a workspace', error.message, 5000)
-      }
+				showNotificationError('Error to create a workspace', error.message, 5000)
+			}
 
 			throw new BadCreateError(error)
 		})

From 414f879f1296c0c80ea65445907653ee67071b2c Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Mon, 4 Nov 2024 11:08:11 +0100
Subject: [PATCH 06/16] style(php): Run composer cs:fix

---
 lib/Controller/WorkspaceController.php        | 15 ++++------
 lib/Exceptions/AbstractNotification.php       | 20 +++++++------
 lib/Middleware/IsGeneralManagerMiddleware.php | 26 ++++++++---------
 lib/Middleware/IsSpaceAdminMiddleware.php     | 28 +++++++++----------
 lib/Space/SpaceManager.php                    |  6 ++--
 5 files changed, 47 insertions(+), 48 deletions(-)

diff --git a/lib/Controller/WorkspaceController.php b/lib/Controller/WorkspaceController.php
index 961809b82..bfe6476eb 100644
--- a/lib/Controller/WorkspaceController.php
+++ b/lib/Controller/WorkspaceController.php
@@ -28,9 +28,6 @@
 use OCA\Workspace\Db\Space;
 use OCA\Workspace\Db\SpaceMapper;
 use OCA\Workspace\Exceptions\BadRequestException;
-use OCA\Workspace\Exceptions\CreateGroupException;
-use OCA\Workspace\Exceptions\CreateWorkspaceException;
-use OCA\Workspace\Exceptions\WorkspaceNameExistException;
 use OCA\Workspace\Folder\RootFolder;
 use OCA\Workspace\Helper\GroupfolderHelper;
 use OCA\Workspace\Service\Group\GroupFormatter;
@@ -66,7 +63,7 @@ public function __construct(
 		private UserGroup $userGroup,
 		private WorkspaceManagerGroup $workspaceManagerGroup,
 		private SpaceManager $spaceManager,
-		public $AppName
+		public $AppName,
 	) {
 		parent::__construct($AppName, $request);
 	}
@@ -90,11 +87,11 @@ public function createWorkspace(string $spaceName): JSONResponse {
 		$workspace = $this->spaceManager->create($spaceName);
 
 		return new JSONResponse(
-				array_merge(
-					$workspace,
-					[ 'statuscode' => Http::STATUS_CREATED ]
-				)
+			array_merge(
+				$workspace,
+				[ 'statuscode' => Http::STATUS_CREATED ]
 			)
+		)
 		;
 	}
 
@@ -170,7 +167,7 @@ public function findAll(): JSONResponse {
 					$this->logger->warning(
 						"Be careful, the $gid group is not exist in the oc_groups table."
 						. " But, it's present in the oc_group_folders_groups table."
-						.  'It necessary to recreate it with the occ command.'
+						. 'It necessary to recreate it with the occ command.'
 					);
 					continue;
 				}
diff --git a/lib/Exceptions/AbstractNotification.php b/lib/Exceptions/AbstractNotification.php
index 8a2f501a4..462880cd7 100644
--- a/lib/Exceptions/AbstractNotification.php
+++ b/lib/Exceptions/AbstractNotification.php
@@ -2,14 +2,16 @@
 
 namespace OCA\Workspace\Exceptions;
 
-abstract class AbstractNotification extends \Exception
-{
-    public function __construct(protected string $title = 'Error', string $message, int $code)
-    {
-        parent::__construct($message, $code);
-    }
+abstract class AbstractNotification extends \Exception {
+	public function __construct(
+		protected string $title = 'Error',
+		string $message,
+		int $code,
+	) {
+		parent::__construct($message, $code);
+	}
 
-    public function getTitle(): string {
-        return $this->title;
-    }
+	public function getTitle(): string {
+		return $this->title;
+	}
 }
diff --git a/lib/Middleware/IsGeneralManagerMiddleware.php b/lib/Middleware/IsGeneralManagerMiddleware.php
index dbf73d075..3ea7c76e9 100644
--- a/lib/Middleware/IsGeneralManagerMiddleware.php
+++ b/lib/Middleware/IsGeneralManagerMiddleware.php
@@ -39,7 +39,7 @@ class IsGeneralManagerMiddleware extends Middleware {
 	public function __construct(
 		private IControllerMethodReflector $reflector,
 		private IRequest $request,
-		private UserService $userService
+		private UserService $userService,
 	) {
 	}
 
@@ -61,18 +61,18 @@ public function afterException($controller, $methodName, Exception $exception):
 			], Http::STATUS_FORBIDDEN);
 		}
 
-        if ($exception instanceof AbstractNotification) {
-            return new JSONResponse([
-                'title' => $exception->getTitle(),
-                'statuscode' => $exception->getCode(),
-                'message' => $exception->getMessage()
-            ], $exception->getCode());
-        }
+		if ($exception instanceof AbstractNotification) {
+			return new JSONResponse([
+				'title' => $exception->getTitle(),
+				'statuscode' => $exception->getCode(),
+				'message' => $exception->getMessage()
+			], $exception->getCode());
+		}
 
-        return new JSONResponse([
-            'statuscode' => $exception->getCode(),
-            'message' => $exception->getMessage(),
-            'trace' => $exception->getTrace()
-        ], $exception->getCode());
+		return new JSONResponse([
+			'statuscode' => $exception->getCode(),
+			'message' => $exception->getMessage(),
+			'trace' => $exception->getTrace()
+		], $exception->getCode());
 	}
 }
diff --git a/lib/Middleware/IsSpaceAdminMiddleware.php b/lib/Middleware/IsSpaceAdminMiddleware.php
index 7168e5bad..4759e778a 100644
--- a/lib/Middleware/IsSpaceAdminMiddleware.php
+++ b/lib/Middleware/IsSpaceAdminMiddleware.php
@@ -40,7 +40,7 @@ public function __construct(
 		private IControllerMethodReflector $reflector,
 		private IRequest $request,
 		private UserService $userService,
-		private SpaceService $spaceService
+		private SpaceService $spaceService,
 	) {
 	}
 
@@ -62,18 +62,18 @@ public function afterException($controller, $methodName, \Exception $exception):
 			], Http::STATUS_FORBIDDEN);
 		}
 
-        if ($exception instanceof AbstractNotification) {
-            return new JSONResponse([
-                'title' => $exception->getTitle(),
-                'statuscode' => $exception->getCode(),
-                'message' => $exception->getMessage()
-            ], $exception->getCode());
-        }
+		if ($exception instanceof AbstractNotification) {
+			return new JSONResponse([
+				'title' => $exception->getTitle(),
+				'statuscode' => $exception->getCode(),
+				'message' => $exception->getMessage()
+			], $exception->getCode());
+		}
 
-        return new JSONResponse([
-            'statuscode' => $exception->getCode(),
-            'message' => $exception->getMessage(),
-            'trace' => $exception->getTrace()
-        ], $exception->getCode());
-    }
+		return new JSONResponse([
+			'statuscode' => $exception->getCode(),
+			'message' => $exception->getMessage(),
+			'trace' => $exception->getTrace()
+		], $exception->getCode());
+	}
 }
diff --git a/lib/Space/SpaceManager.php b/lib/Space/SpaceManager.php
index 4e6b68c2f..d10c75a34 100644
--- a/lib/Space/SpaceManager.php
+++ b/lib/Space/SpaceManager.php
@@ -62,9 +62,9 @@ public function create(string $spacename): array {
 		
 		if ($this->workspaceCheck->isExist($spacename)) {
 			throw new WorkspaceNameExistException(
-                title: 'Error - Duplicate space name',
-                message: "This space or groupfolder already exist. Please, input another space.\nIf \"toto\" space exist, you cannot create the \"tOTo\" space.\nMake sure you the groupfolder doesn't exist."
-            );
+				title: 'Error - Duplicate space name',
+				message: "This space or groupfolder already exist. Please, input another space.\nIf \"toto\" space exist, you cannot create the \"tOTo\" space.\nMake sure you the groupfolder doesn't exist."
+			);
 		}
 
 		$spacename = $this->deleteBlankSpaceName($spacename);

From 5010b3ae5c882df9added70cba3985f91087eaf2 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:22:47 +0100
Subject: [PATCH 07/16] test(js): Declare @deprecated on a few test functions

---
 src/tests/unit/groupfoldersService.test.js | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/tests/unit/groupfoldersService.test.js b/src/tests/unit/groupfoldersService.test.js
index c5038b79c..ae698ed17 100644
--- a/src/tests/unit/groupfoldersService.test.js
+++ b/src/tests/unit/groupfoldersService.test.js
@@ -149,6 +149,9 @@ describe('formatUsers function', () => {
 	})
 })
 
+/**
+ * @deprecated
+ */
 describe('checkGroupfolderNameExist function', () => {
 	beforeEach(() => {
 		axios.mockClear()
@@ -166,6 +169,9 @@ describe('checkGroupfolderNameExist function', () => {
 	})
 })
 
+/**
+ * @deprecated
+ */
 describe('enableAcl function', () => {
 	beforeEach(() => {
 		axios.mockClear()
@@ -182,6 +188,9 @@ describe('enableAcl function', () => {
 	})
 })
 
+/**
+ * @deprecated
+ */
 describe('addGroupToGroupfolder', () => {
 	beforeEach(() => {
 		axios.mockClear()
@@ -207,6 +216,9 @@ describe('addGroupToGroupfolder', () => {
 	})
 })
 
+/**
+ * @deprecated
+ */
 describe('addGroupToManageACLForGroupfolder', () => {
 	beforeEach(() => {
 		axios.mockClear()
@@ -265,6 +277,9 @@ describe('removeGroupToManageACLForGroupfolder', () => {
 	})
 })
 
+/**
+ * @deprecated
+ */
 describe('createGroupfolder', () => {
 	beforeEach(() => {
 		axios.mockClear()

From 71b852f42dde4d4090eddf3144051434c527f77e Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:24:10 +0100
Subject: [PATCH 08/16] test(js): Change the array response when creating a
 workspace

---
 src/tests/unit/workspaceContent.test.js | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/tests/unit/workspaceContent.test.js b/src/tests/unit/workspaceContent.test.js
index c37959bd3..029c0db11 100644
--- a/src/tests/unit/workspaceContent.test.js
+++ b/src/tests/unit/workspaceContent.test.js
@@ -101,10 +101,10 @@ describe('Creating spaces with different entries', () => {
 		expect(mockCreateSpace).toHaveBeenCalled()
 	})
 
-	it('Create "Sri_Lanka"', async () => {
+	it('Create the workspace "Sri_Lanka"', async () => {
 		axios.post.mockResolvedValue({
 			data: {
-				space_name: 'Sri_Lanka',
+				name: 'Sri_Lanka',
 				id_space: 421,
 				folder_id: 809,
 				color: '#b7752e',
@@ -118,10 +118,17 @@ describe('Creating spaces with different entries', () => {
 						gid: 'SPACE-U-421',
 					},
 				},
-				statuscode: 201,
-				acl: {
-					state: true,
-				},
+        quota: -3,
+        size: 0,
+        acl: true,
+        manage: [
+          {
+            type: "group",
+            id: "SPACE-GE-421",
+            displayname: "WM-Sri_Lanka"
+          }
+        ],
+        statuscode: 201
 			},
 		})
 

From b747bb25321751f190875d453f65e2ffe53b8949 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:25:52 +0100
Subject: [PATCH 09/16] test(php): Create unit tests on the special characters
 for a workspace

---
 .../Workspace/WorkspaceCheckServiceTest.php   | 194 ++++++++++++++++++
 1 file changed, 194 insertions(+)
 create mode 100644 tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php

diff --git a/tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php b/tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php
new file mode 100644
index 000000000..ade964e24
--- /dev/null
+++ b/tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php
@@ -0,0 +1,194 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @copyright Copyright (c) 2024 Arawa
+ *
+ * @author 2024 Baptiste Fotia <baptiste.fotia@arawa.fr>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Workspace\Tests\Unit\Service\Workspace;
+
+use OCA\Workspace\Service\SpaceService;
+use OCA\Workspace\Service\Workspace\WorkspaceCheckService;
+use PHPUnit\Framework\TestCase;
+
+class WorkspaceCheckServiceTest extends TestCase {
+
+    private \PHPUnit\Framework\MockObject\MockObject&SpaceService $spaceService;
+    private WorkspaceCheckService $workspaceCheckService;
+    
+    public function setUp(): void {
+        parent::setUp();
+
+        $this->spaceService = $this->createMock(SpaceService::class);
+        $this->workspaceCheckService = new WorkspaceCheckService($this->spaceService);
+    }
+    
+    public function testCheckSpacenameWithoutSpecialCharacter(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01');
+
+        $this->assertFalse($result);
+    }
+
+    public function testCheckSpacenameWithAtSymbol(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Esp@ce01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithPipe(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace|01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithTild(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace~01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithPercent(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Es%pace01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithSlash(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01/Group');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithBackSlash(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01\Group');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithAmpersand(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01&Group');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithEmbraces(): void {
+        $embraceOpened = $this->workspaceCheckService->containSpecialChar('Espace01>Group');
+        $embraceClosed = $this->workspaceCheckService->containSpecialChar('Espace01<Group');
+        $embraces = $this->workspaceCheckService->containSpecialChar('Espace01<Group>');
+
+        $this->assertTrue($embraceOpened);
+        $this->assertTrue($embraceClosed);
+        $this->assertTrue($embraces);
+    }    
+
+    public function testCheckSpacenameWithSemiColon(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01;Group');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithComma(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01,Group');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithDot(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace.01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithColon(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01:Group');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithExclamationMark(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01!');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithQuestionMark(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace01?');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithApostrophe(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace\'01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithSharp(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace#01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithPlus(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace+01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithBrackets(): void {
+        $bracketOpened = $this->workspaceCheckService->containSpecialChar('Espace(01');
+        $bracketClosed = $this->workspaceCheckService->containSpecialChar('Espace01)');
+        $brackets = $this->workspaceCheckService->containSpecialChar('Espace(01)');
+
+        $this->assertTrue($bracketOpened);
+        $this->assertTrue($bracketClosed);
+        $this->assertTrue($brackets);
+    }
+
+    public function testCheckSpacenameWithCircumflexAccent(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace^01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithEqual(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace=01');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithAsterisk(): void {
+        $result = $this->workspaceCheckService->containSpecialChar('Espace*');
+
+        $this->assertTrue($result);
+    }
+
+    public function testCheckSpacenameWithSquareBrackets(): void {
+        $squareBracketOpened = $this->workspaceCheckService->containSpecialChar('Espace[01');
+        $squareBracketClosed = $this->workspaceCheckService->containSpecialChar('Espace01]');
+        $squareBrackets = $this->workspaceCheckService->containSpecialChar('Espace[01]');
+
+        $this->assertTrue($squareBracketOpened);
+        $this->assertTrue($squareBracketClosed);
+        $this->assertTrue($squareBrackets);
+    }
+}

From 50e383b97acab358484b7587594b68a53a20e830 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:26:54 +0100
Subject: [PATCH 10/16] chore(php): Add license and move optional arg at the
 end

---
 lib/Exceptions/AbstractNotification.php | 26 +++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/lib/Exceptions/AbstractNotification.php b/lib/Exceptions/AbstractNotification.php
index 462880cd7..7fbbe4f89 100644
--- a/lib/Exceptions/AbstractNotification.php
+++ b/lib/Exceptions/AbstractNotification.php
@@ -1,12 +1,34 @@
 <?php
 
+/**
+ * @copyright Copyright (c) 2024 Arawa
+ *
+ * @author 2024 Baptiste Fotia <baptiste.fotia@arawa.fr>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
 namespace OCA\Workspace\Exceptions;
 
 abstract class AbstractNotification extends \Exception {
 	public function __construct(
-		protected string $title = 'Error',
-		string $message,
+        string $message,
 		int $code,
+		protected string $title = 'Error',
 	) {
 		parent::__construct($message, $code);
 	}

From 4ef11cbeb799722750db63856d161f3039f85434 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:28:28 +0100
Subject: [PATCH 11/16] chore(php): Use named arguments

---
 lib/Exceptions/WorkspaceNameExistException.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Exceptions/WorkspaceNameExistException.php b/lib/Exceptions/WorkspaceNameExistException.php
index 09708fc8c..8c0e51ad1 100644
--- a/lib/Exceptions/WorkspaceNameExistException.php
+++ b/lib/Exceptions/WorkspaceNameExistException.php
@@ -28,6 +28,6 @@
 
 class WorkspaceNameExistException extends AbstractNotification {
 	public function __construct($title, $message, $code = Http::STATUS_CONFLICT) {
-		parent::__construct($title, $message, $code);
+		parent::__construct(title: $title, message: $message, code: $code);
 	}
 }

From b38494472f91af99c169e94fe38bd3cf4061b6c9 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:29:34 +0100
Subject: [PATCH 12/16] feat(service): Create a color code to generate a hexa
 color

---
 lib/Service/ColorCode.php  | 33 +++++++++++++++++++++++++++++++++
 lib/Space/SpaceManager.php |  4 +++-
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 lib/Service/ColorCode.php

diff --git a/lib/Service/ColorCode.php b/lib/Service/ColorCode.php
new file mode 100644
index 000000000..fdd11d643
--- /dev/null
+++ b/lib/Service/ColorCode.php
@@ -0,0 +1,33 @@
+<?php
+
+/**
+ * @copyright Copyright (c) 2024 Arawa
+ *
+ * @author 2024 Baptiste Fotia <baptiste.fotia@arawa.fr>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Workspace\Service;
+
+class ColorCode {
+    public function generate(): string
+    {
+        // mt_rand() (MT - Mersenne Twister) is taller efficient than rand() function.
+        return '#' . substr(md5(mt_rand()), 0, 6);
+    }
+}
diff --git a/lib/Space/SpaceManager.php b/lib/Space/SpaceManager.php
index d10c75a34..cc4804a72 100644
--- a/lib/Space/SpaceManager.php
+++ b/lib/Space/SpaceManager.php
@@ -31,6 +31,7 @@
 use OCA\Workspace\Exceptions\WorkspaceNameExistException;
 use OCA\Workspace\Folder\RootFolder;
 use OCA\Workspace\Helper\GroupfolderHelper;
+use OCA\Workspace\Service\ColorCode;
 use OCA\Workspace\Service\Group\GroupFormatter;
 use OCA\Workspace\Service\Group\UserGroup;
 use OCA\Workspace\Service\Group\WorkspaceManagerGroup;
@@ -45,6 +46,7 @@ public function __construct(
 		private UserGroup $userGroup,
 		private SpaceMapper $spaceMapper,
 		private WorkspaceManagerGroup $workspaceManagerGroup,
+        private ColorCode $colorCode,
 	) {
 	}
 	
@@ -74,7 +76,7 @@ public function create(string $spacename): array {
 		$space = new Space();
 		$space->setSpaceName($spacename);
 		$space->setGroupfolderId($folderId);
-		$space->setColorCode('#' . substr(md5(mt_rand()), 0, 6));  // mt_rand() (MT - Mersenne Twister) is taller efficient than rand() function.
+		$space->setColorCode($this->colorCode->generate());
 		$this->spaceMapper->insert($space);
 
 

From 1a98629f0c50faadf021465c4e7bb4e4ae9cdd0c Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:30:06 +0100
Subject: [PATCH 13/16] test(php): Create a unit test to create a workspace
 with its exceptions

---
 tests/Unit/Space/SpaceManagerTest.php | 267 ++++++++++++++++++++++++++
 1 file changed, 267 insertions(+)
 create mode 100644 tests/Unit/Space/SpaceManagerTest.php

diff --git a/tests/Unit/Space/SpaceManagerTest.php b/tests/Unit/Space/SpaceManagerTest.php
new file mode 100644
index 000000000..9087c9421
--- /dev/null
+++ b/tests/Unit/Space/SpaceManagerTest.php
@@ -0,0 +1,267 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @copyright Copyright (c) 2024 Arawa
+ *
+ * @author 2024 Baptiste Fotia <baptiste.fotia@arawa.fr>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Workspace\Tests\Unit\Controller;
+
+use OCP\IGroup;
+use PHPUnit\Framework\TestCase;
+use OCA\Workspace\Db\SpaceMapper;
+use OCA\Workspace\Exceptions\AbstractNotification;
+use OCA\Workspace\Folder\RootFolder;
+use OCA\Workspace\Service\ColorCode;
+use OCA\Workspace\Space\SpaceManager;
+use OCA\Workspace\Service\Group\UserGroup;
+use OCA\Workspace\Helper\GroupfolderHelper;
+use PHPUnit\Framework\MockObject\MockObject;
+use OCA\Workspace\Exceptions\BadRequestException;
+use OCA\Workspace\Service\Group\WorkspaceManagerGroup;
+use OCA\Workspace\Exceptions\WorkspaceNameExistException;
+use OCA\Workspace\Service\Workspace\WorkspaceCheckService;
+
+class SpaceManagerTest extends TestCase {
+
+	/**
+	 * @var \PHPUnit\Framework\MockObject\MockObject&GroupfolderHelper
+	 */
+	private GroupfolderHelper $folderHelper;
+
+	private MockObject&RootFolder $rootFolder;
+
+	/**
+	 * @var \PHPUnit\Framework\MockObject\MockObject&WorkspaceCheckService
+	 */
+	private WorkspaceCheckService $workspaceCheck;
+
+	/**
+	 * @var \PHPUnit\Framework\MockObject\MockObject&UserGroup
+	 */
+	private UserGroup $userGroup;
+
+	/**
+	 * @var \PHPUnit\Framework\MockObject\MockObject&SpaceMapper
+	 */
+	private SpaceMapper $spaceMapper;
+
+	/**
+	 * @var \PHPUnit\Framework\MockObject\MockObject&WorkspaceManagerGroup
+	 */
+	private WorkspaceManagerGroup $workspaceManagerGroup;
+
+	private \PHPUnit\Framework\MockObject\MockObject&ColorCode $colorCode;
+
+	private SpaceManager $spaceManager;
+
+	public function setUp(): void {
+		parent::setUp();
+
+		$this->folderHelper = $this->createMock(GroupfolderHelper::class);
+		$this->rootFolder = $this->createMock(RootFolder::class);
+		$this->workspaceCheck = $this->createMock(WorkspaceCheckService::class);
+		$this->userGroup = $this->createMock(UserGroup::class);
+		$this->spaceMapper = $this->createMock(SpaceMapper::class);
+		$this->workspaceManagerGroup = $this->createMock(WorkspaceManagerGroup::class);
+		$this->colorCode = $this->createMock(ColorCode::class);
+
+		$this->spaceManager = new SpaceManager(
+			$this->folderHelper,
+			$this->rootFolder,
+			$this->workspaceCheck,
+			$this->userGroup,
+			$this->spaceMapper,
+			$this->workspaceManagerGroup,
+			$this->colorCode
+		);
+	}
+
+	public function testArrayAfterCreatedTheEspace01Workspace(): void
+	{
+		$this->folderHelper
+			->expects($this->once())
+			->method('createFolder')
+			->with('Espace01')
+			->willReturn(1)
+		;
+
+		$this->rootFolder->
+			expects($this->once())
+			->method('getRootFolderStorageId')
+			->willReturn(1)
+		;
+
+		$this->folderHelper
+			->expects($this->once())
+			->method('getFolder')
+			->with(1, 1)
+			->willReturn([
+				'id' => 1,
+				'mount_point' => 'Espace01',
+				'groups' => [
+				  'SPACE-GE-1' => 31,
+				  'SPACE-U-1' => 31,
+				],
+				'quota' => -3,
+				'size' => 0,
+				'acl' => true,
+				'manage' => [
+				  0 => [
+						'type' => 'group',
+						'id' => 'SPACE-GE-1',
+						'displayname' => 'WM-Espace01',
+					],
+				],
+				'group_details' => [
+				  'SPACE-GE-1' => [
+					'displayName' => 'SPACE-GE-1',
+					'permissions' => 31,
+					'type' => 'group',
+					],
+				  'SPACE-U-1' => [
+					'displayName' => 'SPACE-U-1',
+					'permissions' => 31,
+					'type' => 'group',
+				  ],
+				],
+			])
+		;
+
+		$workspaceManagerGroupMock = $this->createMock(IGroup::class);
+		$workspaceManagerGroupMock
+			->expects($this->any())
+			->method('getGID')
+			->willReturn('SPACE-GE-1')
+		;
+		$workspaceManagerGroupMock
+			->expects($this->once())           
+			->method('getDisplayName')
+			->willReturn('WM-Espace01')
+		;
+
+		$userGroupMock = $this->createMock(IGroup::class);
+		$userGroupMock
+			->expects($this->any())
+			->method('getGID')
+			->willReturn('SPACE-U-1')
+		;
+		$userGroupMock
+			->expects($this->any())
+			->method('getDisplayName')
+			->willReturn('U-Espace01')
+		;
+
+		$this->workspaceManagerGroup
+			->expects($this->any())
+			->method('create')
+			->willReturn($workspaceManagerGroupMock)
+		;
+
+		$this->userGroup
+			->expects($this->once())
+			->method('create')
+			->willReturn($userGroupMock)
+		;
+
+		$this->colorCode
+			->expects($this->once())
+			->method('generate')
+			->willReturn('#a50b1c')
+		;
+
+		$space = $this->spaceManager->create('Espace01');
+
+		$this->assertEquals(
+			$space, 
+			[
+				'name' => 'Espace01',
+				'id_space' => null,
+				'folder_id' => 1,
+				'color' => '#a50b1c',
+				'groups' => [
+					'SPACE-GE-1' => [
+						'gid' => 'SPACE-GE-1',
+						'displayName' => 'WM-Espace01',
+					],
+					'SPACE-U-1' => [
+						'gid' => 'SPACE-U-1',
+						'displayName' => 'U-Espace01',
+					],
+				],
+				'quota' => -3,
+				'size' => 0,
+				'acl' => true,
+				'manage' => [
+					0 => [
+						'type' => 'group',
+						'id' => 'SPACE-GE-1',
+						'displayname' => 'WM-Espace01',
+					],
+				],
+			]
+		);
+	}
+
+	public function testBlankException(): void
+	{
+		$this->expectException(BadRequestException::class);
+		$this->expectExceptionMessage('spaceName must be provided');
+
+		$this->spaceManager->create('');
+	}
+
+	public function testContainSpecialCharInTheWorkspaceName(): void
+	{
+		$this->expectException(BadRequestException::class);
+		$this->expectExceptionMessage('Your Workspace name must not contain the following characters: ' . implode(' ', str_split(WorkspaceCheckService::CHARACTERS_SPECIAL)));
+
+		$this->workspaceCheck
+			->expects($this->once())
+			->method('containSpecialChar')
+			->willReturn(true)
+		;
+
+		$this->spaceManager->create('Esp@ce01');
+	}
+
+	public function testWorkspaceAlreadyExist(): void {
+		$this->expectException(WorkspaceNameExistException::class);
+		$this->expectExceptionMessage("This space or groupfolder already exist. Please, input another space.\nIf \"toto\" space exist, you cannot create the \"tOTo\" space.\nMake sure you the groupfolder doesn't exist.");
+
+		$this->workspaceCheck
+			->expects($this->once())
+			->method('isExist')
+			->willReturn(true)
+		;
+
+		try {
+			$this->spaceManager->create('Espace01');
+		} catch (\Exception|AbstractNotification $e) {
+			$this->assertInstanceOf(\Exception::class, $e);
+			$this->assertInstanceOf(AbstractNotification::class, $e);
+			$this->assertEquals('Error - Duplicate space name', $e->getTitle());
+			$this->assertEquals("This space or groupfolder already exist. Please, input another space.\nIf \"toto\" space exist, you cannot create the \"tOTo\" space.\nMake sure you the groupfolder doesn't exist.", $e->getMessage());
+			throw $e;
+		}
+	}
+}

From b4e581e9d6311b0760f296138b8bbd7870382dd1 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:45:38 +0100
Subject: [PATCH 14/16] style: composer run cs:fix

---
 lib/Exceptions/AbstractNotification.php       |   2 +-
 lib/Service/ColorCode.php                     |   9 +-
 lib/Space/SpaceManager.php                    |   2 +-
 .../Workspace/WorkspaceCheckServiceTest.php   | 226 +++++++++---------
 tests/Unit/Space/SpaceManagerTest.php         |  55 ++---
 5 files changed, 145 insertions(+), 149 deletions(-)

diff --git a/lib/Exceptions/AbstractNotification.php b/lib/Exceptions/AbstractNotification.php
index 7fbbe4f89..3cc39fb79 100644
--- a/lib/Exceptions/AbstractNotification.php
+++ b/lib/Exceptions/AbstractNotification.php
@@ -26,7 +26,7 @@
 
 abstract class AbstractNotification extends \Exception {
 	public function __construct(
-        string $message,
+		string $message,
 		int $code,
 		protected string $title = 'Error',
 	) {
diff --git a/lib/Service/ColorCode.php b/lib/Service/ColorCode.php
index fdd11d643..047ea1a8a 100644
--- a/lib/Service/ColorCode.php
+++ b/lib/Service/ColorCode.php
@@ -25,9 +25,8 @@
 namespace OCA\Workspace\Service;
 
 class ColorCode {
-    public function generate(): string
-    {
-        // mt_rand() (MT - Mersenne Twister) is taller efficient than rand() function.
-        return '#' . substr(md5(mt_rand()), 0, 6);
-    }
+	public function generate(): string {
+		// mt_rand() (MT - Mersenne Twister) is taller efficient than rand() function.
+		return '#' . substr(md5(mt_rand()), 0, 6);
+	}
 }
diff --git a/lib/Space/SpaceManager.php b/lib/Space/SpaceManager.php
index cc4804a72..742763220 100644
--- a/lib/Space/SpaceManager.php
+++ b/lib/Space/SpaceManager.php
@@ -46,7 +46,7 @@ public function __construct(
 		private UserGroup $userGroup,
 		private SpaceMapper $spaceMapper,
 		private WorkspaceManagerGroup $workspaceManagerGroup,
-        private ColorCode $colorCode,
+		private ColorCode $colorCode,
 	) {
 	}
 	
diff --git a/tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php b/tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php
index ade964e24..be5c2e595 100644
--- a/tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php
+++ b/tests/Unit/Service/Workspace/WorkspaceCheckServiceTest.php
@@ -32,163 +32,163 @@
 
 class WorkspaceCheckServiceTest extends TestCase {
 
-    private \PHPUnit\Framework\MockObject\MockObject&SpaceService $spaceService;
-    private WorkspaceCheckService $workspaceCheckService;
-    
-    public function setUp(): void {
-        parent::setUp();
+	private \PHPUnit\Framework\MockObject\MockObject&SpaceService $spaceService;
+	private WorkspaceCheckService $workspaceCheckService;
+	
+	public function setUp(): void {
+		parent::setUp();
 
-        $this->spaceService = $this->createMock(SpaceService::class);
-        $this->workspaceCheckService = new WorkspaceCheckService($this->spaceService);
-    }
-    
-    public function testCheckSpacenameWithoutSpecialCharacter(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01');
+		$this->spaceService = $this->createMock(SpaceService::class);
+		$this->workspaceCheckService = new WorkspaceCheckService($this->spaceService);
+	}
+	
+	public function testCheckSpacenameWithoutSpecialCharacter(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01');
 
-        $this->assertFalse($result);
-    }
+		$this->assertFalse($result);
+	}
 
-    public function testCheckSpacenameWithAtSymbol(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Esp@ce01');
+	public function testCheckSpacenameWithAtSymbol(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Esp@ce01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithPipe(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace|01');
+	public function testCheckSpacenameWithPipe(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace|01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithTild(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace~01');
+	public function testCheckSpacenameWithTild(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace~01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithPercent(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Es%pace01');
+	public function testCheckSpacenameWithPercent(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Es%pace01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithSlash(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01/Group');
+	public function testCheckSpacenameWithSlash(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01/Group');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithBackSlash(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01\Group');
+	public function testCheckSpacenameWithBackSlash(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01\Group');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithAmpersand(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01&Group');
+	public function testCheckSpacenameWithAmpersand(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01&Group');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithEmbraces(): void {
-        $embraceOpened = $this->workspaceCheckService->containSpecialChar('Espace01>Group');
-        $embraceClosed = $this->workspaceCheckService->containSpecialChar('Espace01<Group');
-        $embraces = $this->workspaceCheckService->containSpecialChar('Espace01<Group>');
+	public function testCheckSpacenameWithEmbraces(): void {
+		$embraceOpened = $this->workspaceCheckService->containSpecialChar('Espace01>Group');
+		$embraceClosed = $this->workspaceCheckService->containSpecialChar('Espace01<Group');
+		$embraces = $this->workspaceCheckService->containSpecialChar('Espace01<Group>');
 
-        $this->assertTrue($embraceOpened);
-        $this->assertTrue($embraceClosed);
-        $this->assertTrue($embraces);
-    }    
+		$this->assertTrue($embraceOpened);
+		$this->assertTrue($embraceClosed);
+		$this->assertTrue($embraces);
+	}
 
-    public function testCheckSpacenameWithSemiColon(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01;Group');
+	public function testCheckSpacenameWithSemiColon(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01;Group');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithComma(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01,Group');
+	public function testCheckSpacenameWithComma(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01,Group');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithDot(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace.01');
+	public function testCheckSpacenameWithDot(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace.01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithColon(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01:Group');
+	public function testCheckSpacenameWithColon(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01:Group');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithExclamationMark(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01!');
+	public function testCheckSpacenameWithExclamationMark(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01!');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithQuestionMark(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace01?');
+	public function testCheckSpacenameWithQuestionMark(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace01?');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithApostrophe(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace\'01');
+	public function testCheckSpacenameWithApostrophe(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace\'01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithSharp(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace#01');
+	public function testCheckSpacenameWithSharp(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace#01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithPlus(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace+01');
+	public function testCheckSpacenameWithPlus(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace+01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithBrackets(): void {
-        $bracketOpened = $this->workspaceCheckService->containSpecialChar('Espace(01');
-        $bracketClosed = $this->workspaceCheckService->containSpecialChar('Espace01)');
-        $brackets = $this->workspaceCheckService->containSpecialChar('Espace(01)');
+	public function testCheckSpacenameWithBrackets(): void {
+		$bracketOpened = $this->workspaceCheckService->containSpecialChar('Espace(01');
+		$bracketClosed = $this->workspaceCheckService->containSpecialChar('Espace01)');
+		$brackets = $this->workspaceCheckService->containSpecialChar('Espace(01)');
 
-        $this->assertTrue($bracketOpened);
-        $this->assertTrue($bracketClosed);
-        $this->assertTrue($brackets);
-    }
+		$this->assertTrue($bracketOpened);
+		$this->assertTrue($bracketClosed);
+		$this->assertTrue($brackets);
+	}
 
-    public function testCheckSpacenameWithCircumflexAccent(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace^01');
+	public function testCheckSpacenameWithCircumflexAccent(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace^01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithEqual(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace=01');
+	public function testCheckSpacenameWithEqual(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace=01');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithAsterisk(): void {
-        $result = $this->workspaceCheckService->containSpecialChar('Espace*');
+	public function testCheckSpacenameWithAsterisk(): void {
+		$result = $this->workspaceCheckService->containSpecialChar('Espace*');
 
-        $this->assertTrue($result);
-    }
+		$this->assertTrue($result);
+	}
 
-    public function testCheckSpacenameWithSquareBrackets(): void {
-        $squareBracketOpened = $this->workspaceCheckService->containSpecialChar('Espace[01');
-        $squareBracketClosed = $this->workspaceCheckService->containSpecialChar('Espace01]');
-        $squareBrackets = $this->workspaceCheckService->containSpecialChar('Espace[01]');
+	public function testCheckSpacenameWithSquareBrackets(): void {
+		$squareBracketOpened = $this->workspaceCheckService->containSpecialChar('Espace[01');
+		$squareBracketClosed = $this->workspaceCheckService->containSpecialChar('Espace01]');
+		$squareBrackets = $this->workspaceCheckService->containSpecialChar('Espace[01]');
 
-        $this->assertTrue($squareBracketOpened);
-        $this->assertTrue($squareBracketClosed);
-        $this->assertTrue($squareBrackets);
-    }
+		$this->assertTrue($squareBracketOpened);
+		$this->assertTrue($squareBracketClosed);
+		$this->assertTrue($squareBrackets);
+	}
 }
diff --git a/tests/Unit/Space/SpaceManagerTest.php b/tests/Unit/Space/SpaceManagerTest.php
index 9087c9421..da18d297f 100644
--- a/tests/Unit/Space/SpaceManagerTest.php
+++ b/tests/Unit/Space/SpaceManagerTest.php
@@ -26,20 +26,20 @@
 
 namespace OCA\Workspace\Tests\Unit\Controller;
 
-use OCP\IGroup;
-use PHPUnit\Framework\TestCase;
 use OCA\Workspace\Db\SpaceMapper;
 use OCA\Workspace\Exceptions\AbstractNotification;
+use OCA\Workspace\Exceptions\BadRequestException;
+use OCA\Workspace\Exceptions\WorkspaceNameExistException;
 use OCA\Workspace\Folder\RootFolder;
+use OCA\Workspace\Helper\GroupfolderHelper;
 use OCA\Workspace\Service\ColorCode;
-use OCA\Workspace\Space\SpaceManager;
 use OCA\Workspace\Service\Group\UserGroup;
-use OCA\Workspace\Helper\GroupfolderHelper;
-use PHPUnit\Framework\MockObject\MockObject;
-use OCA\Workspace\Exceptions\BadRequestException;
 use OCA\Workspace\Service\Group\WorkspaceManagerGroup;
-use OCA\Workspace\Exceptions\WorkspaceNameExistException;
 use OCA\Workspace\Service\Workspace\WorkspaceCheckService;
+use OCA\Workspace\Space\SpaceManager;
+use OCP\IGroup;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
 
 class SpaceManagerTest extends TestCase {
 
@@ -96,8 +96,7 @@ public function setUp(): void {
 		);
 	}
 
-	public function testArrayAfterCreatedTheEspace01Workspace(): void
-	{
+	public function testArrayAfterCreatedTheEspace01Workspace(): void {
 		$this->folderHelper
 			->expects($this->once())
 			->method('createFolder')
@@ -107,8 +106,8 @@ public function testArrayAfterCreatedTheEspace01Workspace(): void
 
 		$this->rootFolder->
 			expects($this->once())
-			->method('getRootFolderStorageId')
-			->willReturn(1)
+				->method('getRootFolderStorageId')
+				->willReturn(1)
 		;
 
 		$this->folderHelper
@@ -119,30 +118,30 @@ public function testArrayAfterCreatedTheEspace01Workspace(): void
 				'id' => 1,
 				'mount_point' => 'Espace01',
 				'groups' => [
-				  'SPACE-GE-1' => 31,
-				  'SPACE-U-1' => 31,
+					'SPACE-GE-1' => 31,
+					'SPACE-U-1' => 31,
 				],
 				'quota' => -3,
 				'size' => 0,
 				'acl' => true,
 				'manage' => [
-				  0 => [
+					0 => [
 						'type' => 'group',
 						'id' => 'SPACE-GE-1',
 						'displayname' => 'WM-Espace01',
 					],
 				],
 				'group_details' => [
-				  'SPACE-GE-1' => [
-					'displayName' => 'SPACE-GE-1',
-					'permissions' => 31,
-					'type' => 'group',
+					'SPACE-GE-1' => [
+						'displayName' => 'SPACE-GE-1',
+						'permissions' => 31,
+						'type' => 'group',
+					],
+					'SPACE-U-1' => [
+						'displayName' => 'SPACE-U-1',
+						'permissions' => 31,
+						'type' => 'group',
 					],
-				  'SPACE-U-1' => [
-					'displayName' => 'SPACE-U-1',
-					'permissions' => 31,
-					'type' => 'group',
-				  ],
 				],
 			])
 		;
@@ -154,7 +153,7 @@ public function testArrayAfterCreatedTheEspace01Workspace(): void
 			->willReturn('SPACE-GE-1')
 		;
 		$workspaceManagerGroupMock
-			->expects($this->once())           
+			->expects($this->once())
 			->method('getDisplayName')
 			->willReturn('WM-Espace01')
 		;
@@ -192,7 +191,7 @@ public function testArrayAfterCreatedTheEspace01Workspace(): void
 		$space = $this->spaceManager->create('Espace01');
 
 		$this->assertEquals(
-			$space, 
+			$space,
 			[
 				'name' => 'Espace01',
 				'id_space' => null,
@@ -222,16 +221,14 @@ public function testArrayAfterCreatedTheEspace01Workspace(): void
 		);
 	}
 
-	public function testBlankException(): void
-	{
+	public function testBlankException(): void {
 		$this->expectException(BadRequestException::class);
 		$this->expectExceptionMessage('spaceName must be provided');
 
 		$this->spaceManager->create('');
 	}
 
-	public function testContainSpecialCharInTheWorkspaceName(): void
-	{
+	public function testContainSpecialCharInTheWorkspaceName(): void {
 		$this->expectException(BadRequestException::class);
 		$this->expectExceptionMessage('Your Workspace name must not contain the following characters: ' . implode(' ', str_split(WorkspaceCheckService::CHARACTERS_SPECIAL)));
 

From 0406dd5079575028e443bf82ce0d4d1fbdd444a3 Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Tue, 5 Nov 2024 16:46:56 +0100
Subject: [PATCH 15/16] style: Convert space to tab for indentation and use
 singlequotes

---
 src/tests/unit/workspaceContent.test.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/tests/unit/workspaceContent.test.js b/src/tests/unit/workspaceContent.test.js
index 029c0db11..32340b20d 100644
--- a/src/tests/unit/workspaceContent.test.js
+++ b/src/tests/unit/workspaceContent.test.js
@@ -118,17 +118,17 @@ describe('Creating spaces with different entries', () => {
 						gid: 'SPACE-U-421',
 					},
 				},
-        quota: -3,
-        size: 0,
-        acl: true,
-        manage: [
-          {
-            type: "group",
-            id: "SPACE-GE-421",
-            displayname: "WM-Sri_Lanka"
-          }
-        ],
-        statuscode: 201
+				quota: -3,
+				size: 0,
+				acl: true,
+				manage: [
+					{
+						type: 'group',
+						id: 'SPACE-GE-421',
+						displayname: 'WM-Sri_Lanka'
+					}
+				],
+				statuscode: 201
 			},
 		})
 

From 5b0a141cffbd673889d2f645b671ce12cbf8560a Mon Sep 17 00:00:00 2001
From: zak39 <fotia.baptiste@hotmai.com>
Date: Wed, 6 Nov 2024 11:07:51 +0100
Subject: [PATCH 16/16] test: Declare typed properties for mock objects

---
 tests/Unit/Space/SpaceManagerTest.php | 27 ++++++---------------------
 1 file changed, 6 insertions(+), 21 deletions(-)

diff --git a/tests/Unit/Space/SpaceManagerTest.php b/tests/Unit/Space/SpaceManagerTest.php
index da18d297f..cc1e2cbc7 100644
--- a/tests/Unit/Space/SpaceManagerTest.php
+++ b/tests/Unit/Space/SpaceManagerTest.php
@@ -43,34 +43,19 @@
 
 class SpaceManagerTest extends TestCase {
 
-	/**
-	 * @var \PHPUnit\Framework\MockObject\MockObject&GroupfolderHelper
-	 */
-	private GroupfolderHelper $folderHelper;
+	private MockObject&GroupfolderHelper $folderHelper;
 
 	private MockObject&RootFolder $rootFolder;
 
-	/**
-	 * @var \PHPUnit\Framework\MockObject\MockObject&WorkspaceCheckService
-	 */
-	private WorkspaceCheckService $workspaceCheck;
+	private MockObject&WorkspaceCheckService $workspaceCheck;
 
-	/**
-	 * @var \PHPUnit\Framework\MockObject\MockObject&UserGroup
-	 */
-	private UserGroup $userGroup;
+	private MockObject&UserGroup $userGroup;
 
-	/**
-	 * @var \PHPUnit\Framework\MockObject\MockObject&SpaceMapper
-	 */
-	private SpaceMapper $spaceMapper;
+	private MockObject&SpaceMapper $spaceMapper;
 
-	/**
-	 * @var \PHPUnit\Framework\MockObject\MockObject&WorkspaceManagerGroup
-	 */
-	private WorkspaceManagerGroup $workspaceManagerGroup;
+	private MockObject&WorkspaceManagerGroup $workspaceManagerGroup;
 
-	private \PHPUnit\Framework\MockObject\MockObject&ColorCode $colorCode;
+	private MockObject&ColorCode $colorCode;
 
 	private SpaceManager $spaceManager;