Mismatch Amount

[namnm1991]

Hi Bill,

smartcontract/makefile

Line 249 in 040ed5c

# This will deposit 1 ETH into the two extra accounts from the coinbase account.

Actually this set the deposit amount 4722.366482869645213696 ETH. If you want to change the deposit amount to 1 ETH, please use 0xde0b6b3a7640000

Thanks,

[ardan-bkennedy]

You will have to explain that to me.

[namnm1991]

Hi @ardan-bkennedy,

You could take a look at the change in recipient's balance when you run make geth-deposit. We have 4 recipients here but let's take '0x8E113078ADF6888B7ba84967F299F29AeCe24c55' for example:

Before:

> eth.getBalance("0x8E113078ADF6888B7ba84967F299F29AeCe24c55");
0

After:

> eth.getBalance("0x8E113078ADF6888B7ba84967F299F29AeCe24c55");
4.722366482869645213696e+21

So in fact, you have transferred ~4722.367 ETH (not 1 ETH) from the coinbase address to '0x8E113078ADF6888B7ba84967F299F29AeCe24c55'. If we want to transfer exactly 1 ETH here in geth-deposit, we should change the value from 0x1000000000000000000 to 0xde0b6b3a7640000.

[ardan-bkennedy]

Of you want to provide a PR with a comment I will accept it. I'm guessing you are compensating for fees/gas etc?