Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are join/connected methods virtual? #119

Open
matthijskooijman opened this issue Jun 23, 2022 · 1 comment
Open

Why are join/connected methods virtual? #119

matthijskooijman opened this issue Jun 23, 2022 · 1 comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@matthijskooijman
Copy link

Reading the code, I see that various join methods, and the connected method are declared virtual. Why is this? Are subclasses expected that only subclass these methods? Or is this just a typo / accidental copy-paste?

There are also some other methods overridden from the Stream class that are already virtual there, so those make sense to be virtual.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 27, 2022
@HeadBoffin
Copy link

It would appear to be a muddle, hacked out of a GPS library - certainly not nice clean clear code for alterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthijskooijman @per1234 @HeadBoffin