Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #5474

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Update repositories.txt #5474

merged 2 commits into from
Nov 26, 2024

Conversation

randyb128
Copy link
Contributor

GeoMagnetism Library

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 25, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/DMT-Services/GeoMagnetism

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @randyb128
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@randyb128
Copy link
Contributor Author

Release tag added

@per1234
Copy link
Contributor

per1234 commented Nov 26, 2024

@ArduinoBot please check it again.

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/DMT-Services/GeoMagnetism:

Linting library in GeoMagnetism
INFO: No header file found matching library name (GeoMagnetism.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Missing url field in library.properties                                                               
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP040)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in GeoMagnetism/examples/Simple

Linter results for project: no errors or warnings

-------------------

Linting sketch in GeoMagnetism/examples/WMM

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @randyb128.
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @randyb128. Thanks for your interest in contributing to the Arduino Library Manager index.

I see the bot reported a problem with your submission that will block its acceptance:

ERROR: Missing url field in library.properties                                                               
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP040)    

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Add a url field to the library's library.properties metadata file:
    https://github.com/DMT-Services/GeoMagnetism/blob/main/library.properties
  2. Bump the value of the version field in the library's library.properties metadata file.
  3. Create a new release or tag in the library repository.
  4. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Nov 26, 2024
@arduino arduino deleted a comment from github-actions bot Nov 26, 2024
@arduino arduino deleted a comment from github-actions bot Nov 26, 2024
@arduino arduino deleted a comment from github-actions bot Nov 26, 2024
@randyb128
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Nov 26, 2024
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot removed the request for review from per1234 November 26, 2024 14:06
@github-actions github-actions bot merged commit 6a80cab into arduino:main Nov 26, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/DMT-Services/GeoMagnetism/

github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants