Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncWebSerial #5489

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add AsyncWebSerial #5489

merged 1 commit into from
Nov 28, 2024

Conversation

asessa
Copy link
Contributor

@asessa asessa commented Nov 28, 2024

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 28, 2024
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/circuitcode/AsyncWebSerial:

Linting library in AsyncWebSerial
ERROR: Missing maintainer field in library.properties                                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP025)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in AsyncWebSerial/examples/demo

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @asessa
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@asessa
Copy link
Contributor Author

asessa commented Nov 28, 2024

@ArduinoBot fixed

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/circuitcode/AsyncWebSerial:

Linting library in AsyncWebSerial
ERROR: Missing maintainer field in library.properties                                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP025)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in AsyncWebSerial/examples/demo

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @asessa
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@asessa
Copy link
Contributor Author

asessa commented Nov 28, 2024

@ArduinoBot email fixed

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/circuitcode/AsyncWebSerial:

Linting library in AsyncWebSerial
ERROR: Missing maintainer field in library.properties                                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP025)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in AsyncWebSerial/examples/demo

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @asessa
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@asessa
Copy link
Contributor Author

asessa commented Nov 28, 2024

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/circuitcode/AsyncWebSerial:

Linting library in AsyncWebSerial
ERROR: Missing maintainer field in library.properties                                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP025)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in AsyncWebSerial/examples/demo

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @asessa
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@asessa
Copy link
Contributor Author

asessa commented Nov 28, 2024

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit dfb9514 into arduino:main Nov 28, 2024
12 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/circuitcode/AsyncWebSerial/

github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@asessa asessa deleted the patch-1 branch November 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant