From a76ae07633f712f4accaa12497531edddcbcb258 Mon Sep 17 00:00:00 2001
From: Guillaume Mulocher <gmulocher@arista.com>
Date: Thu, 24 Oct 2024 17:57:33 +0200
Subject: [PATCH] fix(anta.cli): Print multiple messages for anta nrfu text
 (#897)

---
 anta/cli/nrfu/utils.py                     |  8 ++++++--
 tests/data/test_catalog_double_failure.yml | 13 +++++++++++++
 tests/units/cli/conftest.py                |  1 +
 tests/units/cli/nrfu/test_commands.py      | 13 +++++++++++++
 4 files changed, 33 insertions(+), 2 deletions(-)
 create mode 100644 tests/data/test_catalog_double_failure.yml

diff --git a/anta/cli/nrfu/utils.py b/anta/cli/nrfu/utils.py
index 947c08901..375e6e1ed 100644
--- a/anta/cli/nrfu/utils.py
+++ b/anta/cli/nrfu/utils.py
@@ -116,8 +116,12 @@ def print_text(ctx: click.Context) -> None:
     """Print results as simple text."""
     console.print()
     for test in _get_result_manager(ctx).results:
-        message = f" ({test.messages[0]!s})" if len(test.messages) > 0 else ""
-        console.print(f"{test.name} :: {test.test} :: [{test.result}]{test.result.upper()}[/{test.result}]{message}", highlight=False)
+        if len(test.messages) <= 1:
+            message = test.messages[0] if len(test.messages) == 1 else ""
+            console.print(f"{test.name} :: {test.test} :: [{test.result}]{test.result.upper()}[/{test.result}]({message})", highlight=False)
+        else:  # len(test.messages) > 1
+            console.print(f"{test.name} :: {test.test} :: [{test.result}]{test.result.upper()}[/{test.result}]", highlight=False)
+            console.print("\n".join(f"    {message}" for message in test.messages), highlight=False)
 
 
 def print_jinja(results: ResultManager, template: pathlib.Path, output: pathlib.Path | None = None) -> None:
diff --git a/tests/data/test_catalog_double_failure.yml b/tests/data/test_catalog_double_failure.yml
new file mode 100644
index 000000000..0ce48f8d3
--- /dev/null
+++ b/tests/data/test_catalog_double_failure.yml
@@ -0,0 +1,13 @@
+---
+anta.tests.interfaces:
+  - VerifyInterfacesSpeed:
+      interfaces:
+        - name: Ethernet2
+          auto: False
+          speed: 10
+        - name: Ethernet3
+          auto: True
+          speed: 100
+        - name: Ethernet4
+          auto: False
+          speed: 2.5
diff --git a/tests/units/cli/conftest.py b/tests/units/cli/conftest.py
index e63e60eb2..71c23e9c3 100644
--- a/tests/units/cli/conftest.py
+++ b/tests/units/cli/conftest.py
@@ -39,6 +39,7 @@
         errmsg="Invalid command",
         not_exec=[],
     ),
+    "show interfaces": {},
 }
 
 MOCK_CLI_TEXT: dict[str, asynceapi.EapiCommandError | str] = {
diff --git a/tests/units/cli/nrfu/test_commands.py b/tests/units/cli/nrfu/test_commands.py
index 6a2624c1e..817ab7830 100644
--- a/tests/units/cli/nrfu/test_commands.py
+++ b/tests/units/cli/nrfu/test_commands.py
@@ -76,6 +76,19 @@ def test_anta_nrfu_text(click_runner: CliRunner) -> None:
     assert "leaf1 :: VerifyEOSVersion :: SUCCESS" in result.output
 
 
+def test_anta_nrfu_text_multiple_failures(click_runner: CliRunner) -> None:
+    """Test anta nrfu text with multiple failures, catalog is given via env."""
+    result = click_runner.invoke(anta, ["nrfu", "text"], env={"ANTA_CATALOG": str(DATA_DIR / "test_catalog_double_failure.yml")})
+    assert result.exit_code == ExitCode.OK
+    assert (
+        """spine1 :: VerifyInterfacesSpeed :: FAILURE
+    Interface `Ethernet2` is not found.
+    Interface `Ethernet3` is not found.
+    Interface `Ethernet4` is not found."""
+        in result.output
+    )
+
+
 def test_anta_nrfu_json(click_runner: CliRunner) -> None:
     """Test anta nrfu, catalog is given via env."""
     result = click_runner.invoke(anta, ["nrfu", "json"])