Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Update library types to fixed length types #36

Open
arjo129 opened this issue May 21, 2014 · 6 comments
Open

Update library types to fixed length types #36

arjo129 opened this issue May 21, 2014 · 6 comments

Comments

@arjo129
Copy link
Owner

arjo129 commented May 21, 2014

With variations in various boards, it seems necessary to update the library to used u_int16t rather than int. (which was bad practice).

@q2dg
Copy link

q2dg commented Sep 6, 2016

Hello. Is someone out there?

@arjo129
Copy link
Owner Author

arjo129 commented Sep 7, 2016

Hi, what would you like to know?

@q2dg
Copy link

q2dg commented Sep 7, 2016

Hi! If this issue has been resolved. Thanks

@arjo129
Copy link
Owner Author

arjo129 commented Sep 7, 2016

No it hasn't been resolved.

@gonzalj3
Copy link

Hello!
I went ahead and made changes to the uspeech.h file so that it contains u_int16t types instead of int. I also included the appropriate library. I wanted to add a message here because this issue seems a bit dated and I am new to helping in open source projects. In other words I just wanted to confirm that I was helping in an existing issue and that I didnt break anything.

@arjo129
Copy link
Owner Author

arjo129 commented Feb 26, 2017

Yep thanks I'll take a look at the PR just give me a day or two, bit busy. In future you can reference you're pull request by mentioning the pull request number like so #PRnum #44. Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants