Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An FFT may be saved #41

Open
4 tasks
swasilyev opened this issue Dec 1, 2022 · 1 comment
Open
4 tasks

An FFT may be saved #41

swasilyev opened this issue Dec 1, 2022 · 1 comment

Comments

@swasilyev
Copy link

We can save 1 FFT (of 7) if we compute the h_query points in the evaluation form during the setup. We can similarly avoid the division when computing h by normalizing these points by g^n - 1 (evaluations of the vanishing polynomial on the coset).
See the PoC here: https://github.com/achimcc/groth16/pull/1/files

These changes break existing proving keys, though I believe they can be updated. Does it worth the burden?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Pratyush
Copy link
Member

Pratyush commented Dec 5, 2022

I believe this is the R1CS-to-QAP reduction used in Circom, right? If so, then we've added partial support for this in #34. The remaining TODO to support this would be to (a) actually implement the new reduction, and (b) generalize the Groth16 struct to allow using different reduction strategies, via the idea in #34 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants