-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to_matrices
is called before inline_all_lcs
#41
Comments
Adding a comment from #42: Because outlining changes the dimensions of the matrices, we should probably be making the matrices square after outlining, no? |
Is this issue closeable @weikengchen ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current
master
branch may fail to index a circuit because theindex
function would call:in
make_matrices_square_for_indexer
, before callinginline_all_lcs
.As a result, a developer would see "no symbolic LCs".
This problem is indeed fixed in the constraints PR #39 by removing a check in
make_matrices_square_for_indexer
.See https://github.com/arkworks-rs/marlin/pull/39/files#diff-4a24591214fb91bafc31f147e9f82b39471e7a773de92a5a36f0776f434c6158R54
But I think we are not going to merge that PR soon, it may be worthwhile to fix this one sooner. (I will work to finish the constraints PR of poly-commit soon.)
The text was updated successfully, but these errors were encountered: