From cb78fab0efb12cd504181ccad641e6f73e27522c Mon Sep 17 00:00:00 2001 From: Albin Severinson Date: Tue, 6 Feb 2024 12:42:50 +0000 Subject: [PATCH] Check `PodSchedulingContext` for `nil` in `appendLabelsFromJobSchedulingContext` (#61) (#3376) Co-authored-by: Noah Held --- internal/scheduler/metrics/metrics.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/scheduler/metrics/metrics.go b/internal/scheduler/metrics/metrics.go index da578cea950..4bfa38d7b6b 100644 --- a/internal/scheduler/metrics/metrics.go +++ b/internal/scheduler/metrics/metrics.go @@ -329,7 +329,11 @@ func appendLabelsFromJobSchedulingContext(labels []string, jctx *schedulercontex executor, nodeName := executorAndNodeNameFromRun(job.LatestRun()) labels = append(labels, job.GetQueue()) labels = append(labels, executor) - labels = append(labels, jctx.PodSchedulingContext.WellKnownNodeTypeName) + wellKnownNodeType := "" + if pctx := jctx.PodSchedulingContext; pctx != nil { + wellKnownNodeType = pctx.WellKnownNodeTypeName + } + labels = append(labels, wellKnownNodeType) labels = append(labels, nodeName) return labels }