Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify NMEA- and Seatalk-Datagram-Parsing #7

Open
arnegue opened this issue Apr 23, 2024 · 0 comments
Open

Unify NMEA- and Seatalk-Datagram-Parsing #7

arnegue opened this issue Apr 23, 2024 · 0 comments

Comments

@arnegue
Copy link
Owner

arnegue commented Apr 23, 2024 •
edited
Loading

NMEADatagram (not NMEADevice) have own-class NMEA-Parsing (see parse_nmea_sentence)
SeatalkDevice (not SeatalkDatagram) has a method (parse_datagram).

Same with a map about IDs (SeatalkDevice: _seatalk_datagram_map, NMEADatagram: nmea_tag_datagram_map).
Maybe put that into Device-Base-Class?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arnegue