Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping on 'g' on macOS Terminal.app #525

Open
stlee42 opened this issue Aug 19, 2023 · 6 comments
Open

Clipping on 'g' on macOS Terminal.app #525

stlee42 opened this issue Aug 19, 2023 · 6 comments

Comments

@stlee42
Copy link

stlee42 commented Aug 19, 2023

Problem description
Using Recursive Mono Linear Static TTF fonts, the bottom of lower case 'g' gets cut off.

Expected behavior
No clipping.

Screenshots
Screenshot 2023-08-19 at 4 05 58 PM

To Reproduce
Steps to reproduce the behavior:

  1. Use the font on macOS. (This also happens in apps other than Terminal.app like TextEdit)

Environment (please complete the following information):

  • OS: macOS Ventura 13.4 (22F66)
  • Browser: N/A
  • Fonts: TTF static fonts from ArrowType-Recursive-1.085.zip release

Additional context
As with bug #513, the problem is not present in OTF version, though the line gap is increased, which is not desirable.

@kenmcd
Copy link

kenmcd commented Aug 19, 2023

Could be a hinting issue.
The bottom of the g is at -250.
The decender setting is -250.
There is no line gap - it is set to 0.
So the OTF is inside the vertical metrics (and macOS may be hinting it to stay there).
The TTF has the same vertical metrics, but the hinting in the font may be pushing the bottom of the character below what the application is displaying.
Could just be the application rendering is in error (or just dumb - to hint-adjust to clipping).

The TTF hinting is done automatically as the fonts are being generated.
It may be possible to modify the settings for that automatic hinting which may affect this issue.
And the font developer may or may not want to mess around with that.
Manual hinting is very complicated and very time consuming - and not likely to happen.
My guess is if the font developer has the time and the inclination to test automating hinting settings/modifications with these particular applications, and assuming that actually "fixes" this issue, then the earliest this would happen is the next release (whenever that may be).

@stlee42
Copy link
Author

stlee42 commented Aug 20, 2023

actually, on macOS, the fonts are rendered anti-aliased without hinting.

@kenmcd
Copy link

kenmcd commented Aug 20, 2023

actually, on macOS, the fonts are rendered anti-aliased without hinting.

Bad description on my part.
It is doing its own grid-fitting.

@stlee42
Copy link
Author

stlee42 commented Aug 20, 2023

aren't grid-fitting and hinting the exact same thing? at any rate, macOS does not do it.

also, in my case, it is definitely a clipping issue of line height type, not grid-fitting or hinting issue. If you look at the screen shot, you can see that one of the g's on the second line is not clipped and shows the full form. the clipping is intermittent according to how the line is redrawn as you press enter or backspace.

@stlee42 stlee42 changed the title Clipping on 'g' on macOS Terminal.cpp Clipping on 'g' on macOS Terminal.app Aug 23, 2023
@TheKamboy
Copy link

I have the same issue, but with the Kitty terminal.

@TheKamboy
Copy link

I have the same issue, but with the Kitty terminal.

fixed the issue by adding this to the config: modify_font cell_height +2px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants