-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RSS feed validation part of CI #63
Comments
It would be super awesome to have a ci
that not only validates rss feed, but would automate all the things.
Something like:
1. i make a new branch, i.e with name
Episode10, containing just the show nodes markdown file and push this
branch on github.
2. CI kicks in and validates show nodes, then generates:
- rss feed.xml
- update README
- create milestone
- create issue for discussion
- validate all generated files
- long term goal: auto editing of recorded files
3. Create new branch from Epsiode 10 branch and commit and push all CI
generated branches back and creates a pull request.
4. Accept pull request and delete branch or reject pull request and start
whole process again by with editing shownodes markdown file which the
triggers ci and so on :)
Maybe instead of mark down shownodes we could trigger step 1 by writing a
tiny dsl (which basically represents shownodes) in kotlin and commit and
push this dsl file instead of shownodes markdown file...
Just some random ideas...
Artem Zinnatullin :slowpoke: <notifications@github.com> schrieb am Di., 11.
Apr. 2017, 16:45:
… Currently we don't have any CI for the project, but we should since we do
everything through GitHub PRs.
As a first CI step we can add rss feed xml validation as suggested here #61
(comment)
<#61 (comment)>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#63>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjnrgCxQ0ylMtavXuQzhqeAOM903D7Gks5ru5IWgaJpZM4M6M9->
.
|
So I have played around with the idea of auto generating and validating stuff for podcast here: https://github.com/sockeqwe/gitpodcaster @artem-zinnatullin do you think this is going in the right direction and we should investigate further on this approach?
Advantages of this approach:
Disadvantages:
While I really would like to automate all this things and integrate it with the git flow / pull request / review , I'm not sure if the current prototype implementation is going in the right direction. Unfortunately, I can't think of a better implementation right now. Any thoughts / ideas? |
Sorry that it took me so long to answer, here is the feedback: I've cloned the repo and reviewed code, in general, I like the implementation, especially knowing our hugest constraint — podcast hosting as a git repo on GitHub. I was mostly thinking about one thing — commiting autogenerated files into the repo, which is usually a wrong thing to do. So I was looking into ways to migrate hosting of our rss feed files to some real hosting but since we can't change GitHub response for a particular file to a 301 HTTP redirect we only can automatically migrate iTunes listeners (and those who use apps that implement iTunes So knowing all that I think your implementation is good enough (we'll do some PRs haha) and should be used for new episodes! 🎉 |
Agreed, this feels wrong. Maybe we should use master branch to only "host" generated files and a "develop" branch where we commit our episode kotlin files. Then we deploy this to master.
|
Another option is to use this git repo as production deployed by git pushes with full history of what was deployed and another repo for just Kotlin source files. So whenever we put a tag in another repo it launches CI that deploys generated files to this repo! |
Sounds like a good idea!
Artem Zinnatullin :slowpoke: <notifications@github.com> schrieb am Sa., 10.
Juni 2017, 15:42:
… Another option is to use this git repo as production deployed by git
pushes with full history of what was deployed and another repo for just
Kotlin source files.
So whenever we put a tag in another repo it launches CI that deploys
generated files to this repo!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjnrv-rilhdOAdh9zJcH-1CJlejuja4ks5sCp08gaJpZM4M6M9->
.
|
Currently we don't have any CI for the project, but we should since we do everything through GitHub PRs.
As a first CI step we can add rss feed xml validation as suggested here #61 (comment)
The text was updated successfully, but these errors were encountered: