Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to assert cycles are fully dropped #134

Open
lopopolo opened this issue Oct 2, 2022 · 0 comments
Open

Add tests to assert cycles are fully dropped #134

lopopolo opened this issue Oct 2, 2022 · 0 comments
Labels
A-rc Area: Rc smart pointer implementation. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate. E-needs-test Call for participation: Writing correctness tests.

Comments

@lopopolo
Copy link
Member

lopopolo commented Oct 2, 2022 •
edited
Loading

Using a custom inner T that increments / decrements an AtomicU64 on new / drop.

To make sure these are useful under LeakSanitizer too – #102 – let's shove a String field with something like "abc".repeat(100) into the T as well.
@lopopolo lopopolo added E-medium Call for participation: Experience needed to fix: Medium / intermediate. E-help-wanted Call for participation: Help is requested to fix this issue. E-needs-test Call for participation: Writing correctness tests. A-rc Area: Rc smart pointer implementation. labels Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rc Area: Rc smart pointer implementation. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate. E-needs-test Call for participation: Writing correctness tests.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lopopolo