Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle does not compile with Visual Studio #242

Open
LucosidE opened this issue Dec 9, 2021 · 2 comments
Open

Bundle does not compile with Visual Studio #242

LucosidE opened this issue Dec 9, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@LucosidE
Copy link

LucosidE commented Dec 9, 2021

I am running into a problem building using Visual Studio.
The error is as follows:
manif/impl/bundle/Bundle.h(21): error C2947: expecting '>' to terminate template-argument-list, found '<'
Line in question is
using Elements = std::tuple< _T<_Scalar> ... >;
My experience with templates is very limited, any help is appreciated.

Thank you.

@artivis artivis added the bug Something isn't working label Dec 10, 2021
@artivis
Copy link
Owner

artivis commented Dec 10, 2021

Hi,
Thanks for reporting. I am aware of this issue and spent some time investigating it in the past. Unfortunately I don't have a Windows machine at hand which makes it difficult to properly debug.
In the meantime, if you do not need the Bundle class, you can simply comment it out in the CMake files.

@LucosidE
Copy link
Author

Thanks for such a quick reply,

I was hoping to use Bundle, its a fantastic way to combine elements into a larger group and I really like that all the sizes get determined at compile time. I think the performance should be really good.

I'll poke around and try to get MSVC working. If you have any insights please let me know.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants