-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to check if group is compact or not at compile and run time. #261
Comments
Hi @slovak194, This makes sense. Would a static member like the existing |
@joansola Any thought on this? How about the name of such variable?
|
Two questions:
Are'nt all groups in manif compact?
What is the purpose of this information?
Missatge de Jeremie Deray ***@***.***> del dia dj., 19 de
gen. 2023 a les 18:40:
… @joansola <https://github.com/joansola> Any thought on this? How about
the name of such variable?
- Group::Compact
- Group::IsCompact
- something else?
—
Reply to this email directly, view it on GitHub
<#261 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAS2LPKV4ZHIPICAQ7FFOLDWTF4A5ANCNFSM6AAAAAAT5RLSTU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I might be mistaken but I believe they are not.
|
As far as I understand, only purely rotational groups in Manif can be considered compact. Yes, the first step I thought is to provide static member as @artivis has suggested. But there might be another step is to specify the range of unique parametrization for tangent. The purpos on my side is related to the way how covariance for the group is expressed on a tangent space. As it only makes some sense if +- 3 sigma is inside this unique parametrization. Or maybe half of it. Best regards, |
Oh I see. Yes, this makes sense. Would this binary marker compact / non-compact be enough then? How to systematize a specification of the first cover of the manifold by the tangent space? So far, all groups in Is it then generalizable to define the first cover through a maximum radius? I am unsure of these things in the general case. |
I tend to prefer |
Would it be interesting / useful to have a test function in the group indicating whether a tangent vector is in the first cover of the manifold or beyond? Tangent::inFirstCover() --> bool |
Dear @artivis @joansola,
I find it potentially useful to have the possibility to check whether the group is compact or not. Both at compile and run time.
That looks like is a natural property of a group.
Please, let me know what you think.
Best regards,
Alex
The text was updated successfully, but these errors were encountered: