Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "tag" and "id" required properties in YAML metaschema #190

Open
drdavella opened this issue Mar 6, 2019 · 2 comments
Open

Make "tag" and "id" required properties in YAML metaschema #190

drdavella opened this issue Mar 6, 2019 · 2 comments

Comments

@drdavella
Copy link
Contributor

This seems reasonable to me but may require some of the schemas to be modified slightly in order to conform. There may be reasons I'm overlooking for why this isn't going to work, though.
@drdavella drdavella mentioned this issue Mar 11, 2019
Merged
@drdavella drdavella mentioned this issue Mar 27, 2019
Closed
@drdavella
Copy link
Contributor Author

It's possible that tag should not be mandatory since not all schemas end up being associated with YAML tags. For example, a schema may only be included as a reference within another schema.

@braingram
Copy link
Contributor

Using a root-level tag is problematic (see: #269). Requiring id (and checking that it matches the uri registered with asdf) seems beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@braingram @drdavella