Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Linter silently fails on parse error #408

Open
cramertj opened this issue Oct 9, 2024 · 0 comments
Open

[Bug]: Linter silently fails on parse error #408

cramertj opened this issue Oct 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cramertj
Copy link

cramertj commented Oct 9, 2024

What happened?

bazelisk lint with a Python target and ruff configured should complain if ruff.toml is invalid TOML. When using ruff directly, invalid TOML results in an error like:

➜  pigweed git:(2432b18cb) ✗ ruff check
ruff failed
  Cause: Failed to parse /usr/local/google/home/cramertj/src/pigweed/.ruff.toml
  Cause: TOML parse error at line 16, column 11
   |
16 | include = '\.pyi?$'
   |           ^^^^^^^^^
invalid type: string "\\.pyi?$", expected a sequence

But using bazelisk lint silently fails (yet says it has completed successfully!):

➜  pigweed git:(2432b18cb) ✗ bazelisk lint //pw_rpc/py/...
2024/10/09 14:46:44 Using unreleased version at commit 1ff5af18d045e8f30a2a0367470db4e8225a785c
2024/10/09 14:46:44 Using unreleased version at commit 1ff5af18d045e8f30a2a0367470db4e8225a785c
INFO: Analyzed 13 targets (0 packages loaded, 0 targets configured).
INFO: Found 13 targets...
INFO: Elapsed time: 0.132s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Version

Output of bazel --version: aspect 2024.40.2-a7ed65a (with local changes)

How to reproduce

No response

Any other information?

No response

@cramertj cramertj added the bug Something isn't working label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant