[Bug]: Nested .clang-format files are not respected

[cramertj]

What happened?

.clang-format files placed in subdirectories should override the .clang-format file of the workspace root. However, in my tests, .clang-format files in subdirectories were ignored, and their settings were not propagated.

It seems like the nested .clang-format files may be missed by this check:

rules_lint/format/private/format.sh

Line 150 in 559ed12

'YAML') patterns=('*.yml' '*.yaml' '.clang-format' '.clang-tidy' '.gemrc') ;;

Additionally, that list does not seem to mention the new .clang-format-ignore files.

Version

Output of bazel --version: aspect 2024.40.2-a7ed65a (with local changes)

How to reproduce

No response

Any other information?

No response

[alexeagle]

The line you're pointing to is what formats the .clang-tidy file contents, unrelated to how those files are discovered when clang-tidy runs.
Since formatting is a bazel run command, it's not hermetic, and it ought to pick up any files it encounters in the repo.