Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling health checks has no affect #1

Open
magick93 opened this issue Feb 2, 2018 · 1 comment
Open

Disabling health checks has no affect #1

magick93 opened this issue Feb 2, 2018 · 1 comment

Comments

@magick93
Copy link

magick93 commented Feb 2, 2018

In the application.yml there is the following, which I have changed to settings:

endpoints:
  enabled: true
  health:
    enabled: false

However when I deploy to my openshift cluster I can see that the deployment config still has health checks. So it seems this setting doesnt do anything.

@astefanutti
Copy link
Owner

While disabling the heath endpoint from the application.yml actually removes the endpoint, it is not used by the Fabric8 Maven to remove the readiness and liveness probes definitions from the deployment.

The Fabric8 Maven plugin automatically adds these definitions when the spring-boot-starter-actuator dependency is added to the project classpath. While is it possible to configure these in the plugin configuration, e.g.:

<plugin>
    <groupId>io.fabric8</groupId>
    <artifactId>fabric8-maven-plugin</artifactId>
    <configuration>
        <enricher>
            <config>
              <spring-boot-health-check>
                  <port>4444</port>
              </spring-boot-health-check>
            </config>
        </enricher>
    </configuration>
</plugin>

Currently it is not possible to disable the probes aside from removing the spring-boot-starter-actuator dependency. That seems to be sensible, though one can argue that this can be inconsistent with the application.yml configuration. If you still think this is an issue, I'd suggest you create an issue in the Fabric8 Maven plugin project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants