Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for RUF057 with negative ndigits #15221

Closed
UnknownPlatypus opened this issue Jan 2, 2025 · 3 comments · Fixed by #15234
Closed

False positive for RUF057 with negative ndigits #15221

UnknownPlatypus opened this issue Jan 2, 2025 · 3 comments · Fixed by #15234
Assignees
@InSyncWithFoo
Labels
bug Something isn't working preview Related to preview mode features

Comments

@UnknownPlatypus
Copy link
Contributor

ruff propose this change:

-round(150, -2)
+150

which is not valid since round(150, -2) == 200

I believe negative ndigits should be skipped

Related to #14828
@MichaReiser
Copy link
Member

CC: @InSyncWithFoo

@MichaReiser MichaReiser added bug Something isn't working preview Related to preview mode features labels Jan 2, 2025
@InSyncWithFoo
Copy link
Contributor

Got it. Fix coming tomorrow.

@MichaReiser
Copy link
Member

Awesome, thank you

@InSyncWithFoo InSyncWithFoo mentioned this issue Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InSyncWithFoo InSyncWithFoo

Labels
bug Something isn't working preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ruff] Avoid reporting when ndigits is possibly negative (RUF057) InSyncWithFoo/ruff
3 participants
@MichaReiser @UnknownPlatypus @InSyncWithFoo