Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric_components: signature is ambigious #127

Open
fjebaker opened this issue Jul 6, 2023 · 0 comments
Open

metric_components: signature is ambigious #127

fjebaker opened this issue Jul 6, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@fjebaker
Copy link
Member

fjebaker commented Jul 6, 2023

Currently, there are some implemenations that are

metric_components(m::AbstractMetric, x::SVector{4})

and others that are

metric_components(m::AbstractMetric, xt::SVector{2}) # only r and theta components
metric_components(m::AbstractMetric, xt::NTuple{2}) # same as above

The return type is also all over the place.

This is needlessly confusing. Suggest we differentiate metric_components and metric_elements, the prior is used as the implementation, and metric_elements is used as an accessor method?

This also seems complex though...

@fjebaker fjebaker added the help wanted Extra attention is needed label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant