Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision tolerances #29

Open
3 tasks
fjebaker opened this issue Jun 3, 2022 · 1 comment
Open
3 tasks

Precision tolerances #29

fjebaker opened this issue Jun 3, 2022 · 1 comment
Labels
analysis Issue or pull request related to an analysis technique or method enhancement New feature or request integrator Issue or pull request related to integration methods

Comments

@fjebaker
Copy link
Member

fjebaker commented Jun 3, 2022

There's several arbitrarily set precisions in the tests, and more generally some unusually high discrepencies in the values calculated between different methods (see brief mention in this blog post).

We should have a suite of tests that

  • ensures the precisions of all methods are known
  • attempts to minimize any extraneous errors
  • keeps the different integration methods consistent with eachother

I think as an aim, we want our methods to agree within 1e-8 or 1e-9 for relative tolerances. In the literature this isn't really discussed other than occasionally ensuring

$$ g_{\sigma\nu} \dot{u}^\sigma \dot{u}^\nu + \mu^2 < \varepsilon \approx 10^{-8} $$

and even that has a big "-ish" stamped onto the end, as some authors don't even really seem to check that, and others just check whether it agrees with some other simulation.

I think we can do better and quantify the errors more.

@fjebaker fjebaker added enhancement New feature or request integrator Issue or pull request related to integration methods analysis Issue or pull request related to an analysis technique or method labels Jun 3, 2022
@fjebaker fjebaker moved this to In Progress 🦆 in Gradus.jl Jun 3, 2022
@fjebaker fjebaker moved this from In Progress 🦆 to Todo 🐣 in Gradus.jl Jun 3, 2022
@phajy
Copy link
Contributor

phajy commented Feb 6, 2023

There's a typo in the URL. I think you mean this blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Issue or pull request related to an analysis technique or method enhancement New feature or request integrator Issue or pull request related to integration methods
Projects
Status: Todo 🐣
Development

No branches or pull requests

2 participants