From a646c7f9ac5d01cda05a0564c31f9cc38f9d0163 Mon Sep 17 00:00:00 2001 From: Sandro Campos Date: Tue, 19 Nov 2024 10:57:28 -0500 Subject: [PATCH 1/3] Remove lonlat argument from ang2vec --- src/lsdb/core/search/polygon_search.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lsdb/core/search/polygon_search.py b/src/lsdb/core/search/polygon_search.py index 1f29d8c6..fe7e3207 100644 --- a/src/lsdb/core/search/polygon_search.py +++ b/src/lsdb/core/search/polygon_search.py @@ -63,6 +63,6 @@ def get_cartesian_polygon(vertices: list[tuple[float, float]]) -> ConvexPolygon: Returns: The convex polygon object. """ - vertices_xyz = hp.ang2vec(*np.array(vertices).T, lonlat=True) + vertices_xyz = hp.ang2vec(*np.array(vertices).T) edge_vectors = [UnitVector3d(x, y, z) for x, y, z in vertices_xyz] return ConvexPolygon(edge_vectors) From 8bdb4e40c4f296b9f87c53b4003ed0ca14ea5d32 Mon Sep 17 00:00:00 2001 From: Sandro Campos Date: Tue, 19 Nov 2024 12:58:09 -0500 Subject: [PATCH 2/3] Install hats from margin branch --- docs/requirements.txt | 4 ++-- requirements.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/requirements.txt b/docs/requirements.txt index 6a734805..8cd6da74 100644 --- a/docs/requirements.txt +++ b/docs/requirements.txt @@ -10,5 +10,5 @@ sphinx-autoapi sphinx-copybutton sphinx-book-theme sphinx-design -git+https://github.com/astronomy-commons/hats.git@main -git+https://github.com/astronomy-commons/hats-import.git@main +git+https://github.com/astronomy-commons/hats.git@margin +git+https://github.com/astronomy-commons/hats-import.git@margin diff --git a/requirements.txt b/requirements.txt index 54865347..f2b394e4 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,3 +1,3 @@ -git+https://github.com/astronomy-commons/hats.git@main +git+https://github.com/astronomy-commons/hats.git@margin git+https://github.com/lincc-frameworks/nested-pandas.git@main git+https://github.com/lincc-frameworks/nested-dask.git@main \ No newline at end of file From 791800d073880ecf2484c7b72b04a93aa32f9339 Mon Sep 17 00:00:00 2001 From: Sandro Campos Date: Tue, 19 Nov 2024 13:01:15 -0500 Subject: [PATCH 3/3] Run tests and pre-commit in margin branch --- .github/workflows/pre-commit-ci.yml | 2 +- .github/workflows/testing-and-coverage.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pre-commit-ci.yml b/.github/workflows/pre-commit-ci.yml index f31b3ee6..642e7b9d 100644 --- a/.github/workflows/pre-commit-ci.yml +++ b/.github/workflows/pre-commit-ci.yml @@ -7,7 +7,7 @@ on: push: branches: [ main ] pull_request: - branches: [ main ] + branches: [ main, margin ] jobs: pre-commit-ci: diff --git a/.github/workflows/testing-and-coverage.yml b/.github/workflows/testing-and-coverage.yml index 11c13d05..b318df50 100644 --- a/.github/workflows/testing-and-coverage.yml +++ b/.github/workflows/testing-and-coverage.yml @@ -7,7 +7,7 @@ on: push: branches: [ main ] pull_request: - branches: [ main ] + branches: [ main, margin ] jobs: build: