You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There are some fundamental problems found in the Payload implementation.
Referring to this
a. The design requirement is to make Payload system generatable, but we cannot refer the generated code back in our source code. Creating this import cycle ourselves will simply create problems.
b. We discuss that if we don't have anything special methods for TextPayload, then we shouldn't add them into top.py. But if we need to have them there then we should.
Some conversations in the PR are not resolved, make sure to resolve all conversations before merging.
Let's not use todo, if we don't track them in issues they will sit there forever.
The text was updated successfully, but these errors were encountered:
Describe the bug
There are some fundamental problems found in the Payload implementation.
a. The design requirement is to make
Payload
system generatable, but we cannot refer the generated code back in our source code. Creating this import cycle ourselves will simply create problems.b. We discuss that if we don't have anything special methods for
TextPayload
, then we shouldn't add them intotop.py
. But if we need to have them there then we should.todo
, if we don't track them in issues they will sit there forever.The text was updated successfully, but these errors were encountered: