Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems in a prior Payload PR #855

Open
hunterhector opened this issue Jul 5, 2022 · 0 comments
Open

Problems in a prior Payload PR #855

hunterhector opened this issue Jul 5, 2022 · 0 comments
Assignees

Comments

@hunterhector
Copy link
Member

hunterhector commented Jul 5, 2022

Describe the bug
There are some fundamental problems found in the Payload implementation.

  1. Referring to this
    a. The design requirement is to make Payload system generatable, but we cannot refer the generated code back in our source code. Creating this import cycle ourselves will simply create problems.
    b. We discuss that if we don't have anything special methods for TextPayload, then we shouldn't add them into top.py. But if we need to have them there then we should.
  2. Some conversations in the PR are not resolved, make sure to resolve all conversations before merging.
  3. Let's not use todo, if we don't track them in issues they will sit there forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants