Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new set of DataPack interfaces to add/get/delete entries without class objects #881

Open
mylibrar opened this issue Jul 14, 2022 · 1 comment
Labels
data_efficiency topic: interface The design and implementation of the Forte interface

Comments

@mylibrar
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Now that we have introduced DataStore into Forte, DataPack is no longer required to handle or maintain entry class objects. However, the current interface still require users to handle entry objects (e.g., delete_entry, add_entry, get_entry). We should design a new set of interfaces to add/get/delete entries and they should interact with entry data with only consists of primitive types and built-in list/dict.

Describe the solution you'd like

  • DataPack should accept onto_file_path and be able to parse it using DataStore. This can eliminate the needs for users to import all the entry classes.
  • Design schema for a more user-friendly representation of entry data. Currently we store entry as list of attributes in DataStore, which is not very convenient for users to use.
  • Implement DataPack.add_entry_raw, DataPack.get_entry_raw, DataPack.delete_entry_raw, etc. These new interfaces only interact with the new entry representation that you designed in last step.

Describe alternatives you've considered
We can compare and discuss the trade-offs of different designs.

Additional context
This is blocked by #874

@mylibrar
Copy link
Collaborator Author

mylibrar commented Jan 3, 2023

Hi @Pushkar-Bhuse, did you have a second PR for this issue? #900 is already merged and you can now push the rest of the codes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data_efficiency topic: interface The design and implementation of the Forte interface
Projects
None yet
Development

No branches or pull requests

1 participant