-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Slack groups are not updated #1658
Comments
I'm labeling as |
more details about current automation: https://github.com/asyncapi/community/blob/master/.github/workflows/slack/README.md?plain=1 |
Just putting the docs here, if somebody plans to take it up: As well as the related workflow: |
@derberg @Shurtu-gal can you please assign me this issue. It will be great starting issue for me |
Issues are not assigned except for bounty and mentorship ones. Feel free to submit a PR. |
@Shurtu-gal ok will submit a pr soon |
Also was just looking through the action logs. I thing format of couple of files have changed. Need to fix that. |
@Shurtu-gal can you help me getting started with this issue |
Hey @fmvilas @Shurtu-gal I think i have a solution for this. I am thinking of making update-slack.yaml file and a python script. The python script will handle all the logic of this task. Am I in the right direction??? Your suggestions will be really helpful |
Looking thorough logs and inspecting the cause seems that terraform init is failing. Looks like ubuntu removed terraform support form their latest 24.04 as seen here To fix it we can setup terraform separately. |
I honestly have no idea about the underlying issue. Just came here to say that OpenTofu is now the OSS version of Terraform and we might have to switch to it instead. |
@Shurtu-gal going through current slack groups implementation and also the terraform docs i think implementation is fine but the reason @fmvilas faced this issue is due to deployment issue occurring due to missing terraform dependency in ubuntu-latest. For PR of this issue should i go with a temporary fix to install terraform or go with the opensource version implementation of terraform which is suggested above. Let me know you thoughts on this. |
@Shurtu-gal digging more into the issue i found this issue which suggests to use Please update. |
Yes, please. Just remember to test it out by making a slack workspace and running the workflow. |
Sure will raise a pr with fix 👍🏻. |
Describe the bug.
When a repo is removed from the list of repos of a user in the MAINTAINERS.yaml file, the Slack user groups are not updated. For instance, I was a maintainer of the website repository and, therefore, I was added as part of the
@maintainers_website
Slack group. However, I stopped being a maintainer of the website repo but I'm still part of the@maintainers_website
Slack group.Expected behavior
If a user removes a repo from their list, they should also be removed from the correspondent
@maintainers_[repo]
Slack group.Screenshots
No relevant screenshots.
How to Reproduce
Explained in the description above.
🥦 Browser
None
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue ?
No, someone else can work on it
The text was updated successfully, but these errors were encountered: