Merge pull request #293 from atilaneves/faster-dub-configs

Eagerly allocate allConfigurationsAsStrings
atilaneves · Apr 11, 2024 · 5260790 · 5260790
2 parents fe08d8d + 65df2b4
commit 5260790
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/payload/reggae/dub/interop/dublib.d b/payload/reggae/dub/interop/dublib.d
@@ -185,18 +185,19 @@ package struct Dub {
             .configurations
             .filter!(c => c.matchesPlatform(_generatorSettings.platform))
             .map!(c => c.name)
+            .array
             ;
 
         if (!allConfigs) { // i.e. one single config specified by the user
             // translate `unittest` to the actual test configuration
             const requestedConfig = haveSpecialTestConfig ? testConfig : singleConfig;
 
 
-            const canFindConfig = allConfigurationsAsStrings.save.canFind(requestedConfig);
+            const canFindConfig = allConfigurationsAsStrings.canFind(requestedConfig);
             if (!canFindConfig && requestedConfig != "default")
                 throw new Exception(
                     text("Unknown dub configuration `", requestedConfig, "` - known configurations:\n    ",
-                         allConfigurationsAsStrings.save)
+                         allConfigurationsAsStrings)
                 );
             // if the user requests "default", then give them the
             // first available configuration, whether or not it's
@@ -210,7 +211,6 @@ package struct Dub {
         }
 
         auto configurations = allConfigurationsAsStrings
-            .save
             // exclude unittest config if there's a derived special one
             .filter!(n => !haveSpecialTestConfig || n != "unittest")
             .array;