Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move metrics inside controller (not global) #95

Open
awprice opened this issue Apr 18, 2018 · 0 comments
Open

Move metrics inside controller (not global) #95

awprice opened this issue Apr 18, 2018 · 0 comments
Labels
enhancement New feature or request
Projects
Escalator

Comments

@awprice
Copy link
Member

awprice commented Apr 18, 2018

At the moment, metrics are global and can be used by just calling metrics.<metric-name>. They should ideally be part of the controller package. This will make it easier in the future when we will need to test the controller package, we can easily mock out the metrics provider.
@awprice awprice added the enhancement New feature or request label Apr 18, 2018
@awprice awprice added this to Pending in Escalator via automation Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Escalator
  
Pending
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awprice