From b261356f15b9830ee28c23f1f89ae5e54f79d091 Mon Sep 17 00:00:00 2001
From: "mike.stackhouse" <mike.stackhouse@atorusresearch.com>
Date: Tue, 13 Feb 2024 19:45:21 +0000
Subject: [PATCH] PR review comments.

---
 R/count.R |  1 -
 R/desc.R  | 16 ----------------
 2 files changed, 17 deletions(-)

diff --git a/R/count.R b/R/count.R
index c896a930..49a6e15f 100644
--- a/R/count.R
+++ b/R/count.R
@@ -108,7 +108,6 @@ process_summaries.count_layer <- function(x, ...) {
 
     process_count_denoms(x)
 
-    outer <- FALSE
     process_single_count_target(x)
 
   }
diff --git a/R/desc.R b/R/desc.R
index 829da546..40e36686 100644
--- a/R/desc.R
+++ b/R/desc.R
@@ -59,22 +59,6 @@ process_summaries.desc_layer <- function(x, ...) {
         ungroup()
 
       num_sums_raw[[i]] <- complete_and_limit(cmplt1, treat_var, by, cols, limit_data_by=limit_data_by)
-      # num_sums_raw[[i]] <- cmplt1 %>%
-      #   # complete all combinations of factors to include combinations that don't exist.
-      #   # add 0 for combinations that don't exist
-      #   complete(!!treat_var, !!!by, !!!cols)
-      #
-      # # Apply data limits specified by setter
-      # if (exists("limit_data_by")) {
-      #   # Find the combinations actually in the data
-      #   groups_in_data <- cmplt1 %>%
-      #     distinct(!!!limit_data_by)
-      #
-      #   # Join back to limit the completed levels based on the preferred
-      #   # data driven ones
-      #   num_sums_raw[[i]] <- groups_in_data %>%
-      #     left_join(num_sums_raw[[i]], by = map_chr(limit_data_by, as_name))
-      # }
 
       # Create the transposed summary data to prepare for formatting
       trans_sums[[i]] <- num_sums_raw[[i]] %>%