Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how population data works to trigger denominators #134

Closed
mstackhouse opened this issue Sep 19, 2023 · 0 comments · Fixed by #157
Closed

Clarify how population data works to trigger denominators #134

mstackhouse opened this issue Sep 19, 2023 · 0 comments · Fixed by #157
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@mstackhouse
Copy link
Contributor

mstackhouse commented Sep 19, 2023

https://atorus-research.github.io/Tplyr/articles/table.html#population-data

Before this text “With the table level settings under control, now you’re ready to learn more about what Tplyr has to offer in each layer.”

Something like Note: it’s expected the set_distinct_by() function is used with population data. This is because it does not make sense to use population data denominators unless you have distinct counts. The entire point of population data is to use subject counts, so non-distinct counts would potentially count multiple records per subject and then the percentage doesn’t make any sense.

@mstackhouse mstackhouse added documentation Improvements or additions to documentation good first issue Good for newcomers labels Sep 19, 2023
@ShiyuC ShiyuC self-assigned this Dec 14, 2023
@ShiyuC ShiyuC linked a pull request Dec 14, 2023 that will close this issue
2 tasks
@ShiyuC ShiyuC closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants