New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and remove dead code #155

Closed

2 tasks

mstackhouse opened this issue Dec 14, 2023 · 1 comment

Assignees

Contributor

mstackhouse commented Dec 14, 2023

There are several sections of code that aren't truly necessary (or never were necessary) anymore that should be dropped.

Tplyr/R/table.R

Line 45 in 6876054

if(missing(target)){
Tplyr/R/layer.R

Line 106 in 6876054

as_tplyr_layer.tplyr_subgroup_layer <- function(parent, target_var, by, where, type, ...) {

<- this concept doesn't actually exist

Other untested lines of code should be re-evaluated based on code coverage.

mstackhouse self-assigned this

mstackhouse mentioned this issue

Code clean-up #167

Merged

Contributor Author

mstackhouse commented Feb 14, 2024

Closed via #167

mstackhouse closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment