-
Notifications
You must be signed in to change notification settings - Fork 16
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply_row_masks()
doesn't respect descending sorting of row break variables
#50
Comments
One way to resolve this would be to capture apply_row_masks(row_breaks = TRUE, ord_layer_index, desc(ord_layer_1))
If there's a stacking method that could respect variable grouping, this could be avoided - but I'm not seeing that in the tidyverse. |
Prerequisites
For more information, see the
CONTRIBUTING
guide.Description
apply_row_masks()
is intended to be used post-sorting, as it blanks row labels out assuming that the repetitive values are already next to each other. Currently, if using additional break variables to insert row breaks, this fails to consider if one of the break variables has been sorted in descending order, leading to an unexpected result.Steps to Reproduce (Bug Report Only)
Expected behavior: [What you expected to happen]
CONGENITAL, FAMILIAL AND GENETIC DISORDERS should sort first, and IMMUNE SYSTEM DISORDERS should sort second.
Actual behavior: [What actually happened]
IMMUNE SYSTEM DISORDERS sorts first and CONGENITAL, FAMILIAL AND GENETIC DISORDERS sorts second. Ascending sorting is reimplemented for ord_layer_1.
** Workaround **
The desired sort order can be achieved by re-sorting the data with the newly added ord_break variable.
This is far from desirable, but it works.
The text was updated successfully, but these errors were encountered: