From a81cf50243ff28d5314c9c87d1f83c5bedfb41ee Mon Sep 17 00:00:00 2001 From: bs832471 Date: Wed, 14 Jun 2023 17:41:46 +0000 Subject: [PATCH] review: #84 comments from PR review --- DESCRIPTION | 2 +- man/length_log.Rd | 2 +- vignettes/deepdive.Rmd | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index ae112e4e..75421e2d 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -82,4 +82,4 @@ Suggests: Config/testthat/edition: 3 VignetteBuilder: knitr Depends: - R (>= 2.10) + R (>= 3.5) diff --git a/man/length_log.Rd b/man/length_log.Rd index 8bbc1d63..8b550292 100644 --- a/man/length_log.Rd +++ b/man/length_log.Rd @@ -7,7 +7,7 @@ length_log(miss_vars, verbose) } \arguments{ -\item{miss_vars}{Variables missing from metatdata} +\item{miss_vars}{Variables missing from metadata} \item{verbose}{Provides additional messaging for user} } diff --git a/vignettes/deepdive.Rmd b/vignettes/deepdive.Rmd index ec3725c5..d2fd6fe4 100644 --- a/vignettes/deepdive.Rmd +++ b/vignettes/deepdive.Rmd @@ -165,7 +165,7 @@ adsl %>% For the next six sections, we are going to explore the Warnings and Errors messages generated by the `{xportr}` core functions. To better explore these, we will either manipulate the ADaM dataset or specification file to help showcase the ability of the `{xportr}` functions to detect issues. -**NOTE:** We have made the ADSL, `adsl`, and Specification File, `var_spec`, available in this package. Users can find additional datasets and specification files on our [repo](https://github.com/atorus-research/xportr) in the `example_data_specs` folder. We have not included these in our package to help keep the package to a minimum size. +**NOTE:** We have made the ADSL, `xportr::adsl`, and Specification File, `xportr::var_spec`, available in this package. Users can find additional datasets and specification files on our [repo](https://github.com/atorus-research/xportr) in the `example_data_specs` folder. ### Setting up our metadata object