Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xportr_length: Set ---DTC variables length to maximum length based Date (10) or Date/Time (19) #207

Closed
bms63 opened this issue Dec 15, 2023 · 1 comment · Fixed by #238
Closed

xportr_length: Set ---DTC variables length to maximum length based Date (10) or Date/Time (19) #207

bms63 opened this issue Dec 15, 2023 · 1 comment · Fixed by #238
Assignees
@cpiraux

Comments

@bms63
Copy link
Collaborator

bms63 commented Dec 15, 2023

Update to xportr_length() that sets DTC variables to maximum length based on Date (10) or Date/Time (19) inputs.

Add a check/warning when the spec length is populated for the --DTC variables as the define.xml should not have a length (missing).
@bms63 bms63 linked a pull request Feb 13, 2024 that will close this issue
Closes #161 Coercion date datatype #214
Merged
14 tasks
@bms63 bms63 closed this as completed Feb 13, 2024
@cpiraux cpiraux removed a link to a pull request Feb 15, 2024
Closes #161 Coercion date datatype #214
Merged
14 tasks
@cpiraux
Copy link
Collaborator

cpiraux commented Feb 15, 2024

Reopen the issue as it is not yet implemented. To much issues with DTC variables 😅

@cpiraux cpiraux reopened this Feb 15, 2024
@cpiraux cpiraux linked a pull request Feb 15, 2024 that will close this issue
Closes #207 xportr_length for missing length in metadata #238
Merged
15 tasks
@bms63 bms63 mentioned this issue Feb 15, 2024
Closed
bms63 added a commit that referenced this issue Feb 20, 2024
@bms63
fix: #207 increase cyclomatic complexity
34a6b95
bms63 added a commit that referenced this issue Feb 20, 2024
@bms63
Merge pull request #238 from atorus-research/207-length-DTC-varaible
e37adb0 
Closes #207 xportr_length for missing length in metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpiraux cpiraux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #207 xportr_length for missing length in metadata atorus-research/xportr
2 participants
@bms63 @cpiraux