Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to do #4

Open
10 of 20 tasks
eeholmes opened this issue May 2, 2023 · 2 comments
Open
10 of 20 tasks

to do #4

eeholmes opened this issue May 2, 2023 · 2 comments
Assignees

Comments

@eeholmes
Copy link
Contributor

eeholmes commented May 2, 2023

  • add tinitx so x0 can be at 0
  • estimate_marss2() is slow. Try logging the diagonal and then Q.diagonal() = Q.diagonal().exp(); https://stackoverflow.com/questions/33834873/modify-eigen-matrix-diagonal. vector diag_exp = Q.diagonal().array().exp();` Q.diagonal().array() = diag.exp;
  • Not handling convergence messages from nlminb
  • add Q estimation (diag or unconstrained)
  • nlminb not picking up maxit? check might have been the print issue that I fixed
  • check tinitx = 0 and V0 not zero
  • allow zeros on diagonal of R and Q
  • add D estimation; cutting out all the extraneous stuff to make just like MARSS
  • add C estimation
  • fix the print out. something is off with metadata
  • I bet CRAN will complain re ::: what to do?
  • Add in test for marssTMB being installed and loaded if method="TMB"
  • Revamp the vignettes
  • Add vignette for model comparisons/testing

LATER

  • Add G and H to allow zeros on the diagonal of Q and R
  • Test time-varying Q and R
  • look into how to do equal var cov; the diag splitting didn't work.

MARSS

  • add method="TMB"
  • fix the error with iterations for optim. should be counts[2]
  • need Rd file for MARSS::MARSSfit
@ericward-noaa
Copy link
Contributor

Also -- at some point, change the parameter matrices to arrays to allow them to be time-varying like MARSS? Or add that on later?

@eeholmes eeholmes self-assigned this May 4, 2023
@eeholmes
Copy link
Contributor Author

@ericward-noaa I think I got the time-varying code working. All models that can be fit with BFGS should be able to be fit now with TMB. Will need latest marssTMB installed but after just call MARSS(..., method="TMB") use BFGS_TMB to use optim() instead of nlminb().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants