Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NotificationResponseTransformer respect atNotification.isEncrypted == false #1332

Closed
gkc opened this issue Jun 10, 2024 · 2 comments · Fixed by #1374
Closed

Make NotificationResponseTransformer respect atNotification.isEncrypted == false #1332

gkc opened this issue Jun 10, 2024 · 2 comments · Fixed by #1374
Assignees
Labels
bug Something isn't working

Comments

@gkc
Copy link
Contributor

gkc commented Jun 10, 2024

Describe the bug

If a client receives a notification where isEncrypted is explicitly false, it nonetheless continues to treat it as though isEncrypted were true

Steps to reproduce

Came across this bug when I was running an sshnpd with legacy atKeys at the same time as I was doing enroll requests; the enroll request notifications explicitly have isEncrypted == false (which is correct) but NotificationResponseTransformer nonetheless tries to decrypt the data and of course fails

Expected behavior

explicit isEncrypted == false should be respected

Additional context

See also atsign-foundation/at_server#1944

@gkc
Copy link
Contributor Author

gkc commented Jun 24, 2024

Will work on this once this at_server PR has been merged and rolled out to prod

@gkc
Copy link
Contributor Author

gkc commented Jul 8, 2024

Will complete in this sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants