Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optional param encryptValue to NotificationService notify method #1390

Closed
murali-shris opened this issue Sep 6, 2024 · 0 comments · Fixed by #1391
Closed

add optional param encryptValue to NotificationService notify method #1390

murali-shris opened this issue Sep 6, 2024 · 0 comments · Fixed by #1391
Assignees
@murali-shris
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

Is your feature request related to a problem? Please describe.

atsign-foundation/at_server#1944

Describe the solution you'd like

Implement the recommendation mentioned in the server ticket
at_client

  • NotificationServiceImpl.notify
    • add an optional bool parameter encryptValue default it to true
    • set the metadata.isEncrypted to the value of encryptValue

Describe alternatives you've considered

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murali-shris murali-shris

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add optional param encryptValue to notify method atsign-foundation/at_client_sdk
1 participant
@murali-shris