Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APKAM: Onboarding Widget Updates #92

Closed
6 tasks done
XavierChanth opened this issue Jun 25, 2023 · 25 comments
Closed
6 tasks done

APKAM: Onboarding Widget Updates #92

XavierChanth opened this issue Jun 25, 2023 · 25 comments
Assignees

Comments

@XavierChanth
Copy link
Member

XavierChanth commented Jun 25, 2023

Standalone Widget which can optionally be included in the onboarding widget:

Requesting App

Standalone widget for approving side

Receiving App

Blocking: atsign-foundation/noports#163

@gkc
Copy link
Contributor

gkc commented Jul 10, 2023

Added this ticket to our main project sprint planning board. Set as P0 as it needs to get started during this sprint. Needs to be estimated at planning poker.

@XavierChanth XavierChanth changed the title APKAM: Widget to issue pkams APKAM: Onboarding Widget Updates Jul 10, 2023
@sitaram-kalluri
Copy link
Member

@CurtlyCritchlow : The APKAM changes in at_client SDK are in srk_apkam_changes

@murali-shris
Copy link
Member

@CurtlyCritchlow please update this task with the progress

@CurtlyCritchlow
Copy link
Contributor

CurtlyCritchlow commented Aug 7, 2023

_

@CurtlyCritchlow
Copy link
Contributor

I built the APKAM Request widget but I got stuck trying connect to vip.ve.atsign.zone. The production server doesn't have the necessary code changes as yet. @sitaram-kalluri and @murali-shris are helping me get unblock.

@sitaram-kalluri
Copy link
Member

Spent 5 SP in PR-68.
Completed implementation of APKAM-UI for the following
In receiving app:

  • notification screen to receive the enrollment notifications
  • Approve/Deny Notifications
  • Generate and display OTP
    In requesting app:
  • Send request for enrollment
  • List enrollments.

The changes are available in https://github.com/atsign-foundation/at_widgets/tree/at_enrollment_service

@sitaram-kalluri sitaram-kalluri self-assigned this Aug 21, 2023
@gkc
Copy link
Contributor

gkc commented Oct 11, 2023

@CurtlyCritchlow @sitaram-kalluri @murali-shris what's latest status on this?

@sitaram-kalluri
Copy link
Member

@gkc: The demo app we have currently is functionally working:

  • An enrollment screen to submit an enrollment request.
  • Notifications screen which display the enrollment requests. Approve or deny the enrollment request.
  • A widget to display the OTP.
  • Upon approving the enrollment, on the app that has submitted the enrollment, a .atKeys file is generated with APKAM keys and user can successfully login with the APKAM .atKeys file.

@gkc
Copy link
Contributor

gkc commented Oct 11, 2023

Thank you @sitaram-kalluri

Are these available as widgets? Is there documentation? How would I (1) build an app which handles enrollment requests (list enrollments, generate OTPs, receive enrollment request notifications and approve or deny them (2) build an app which can make an enrollment request, and complete enrollment if approved?

@sitaram-kalluri
Copy link
Member

Thank you @sitaram-kalluri

Are these available as widgets? Is there documentation? How would I (1) build an app which handles enrollment requests (list enrollments, generate OTPs, receive enrollment request notifications and approve or deny them (2) build an app which can make an enrollment request, and complete enrollment if approved?

@gkc: Yes, the above functionality is available as widgets. Updated the README of the at_enrollment_app package on how to use it.

Attaching the README link here:README

@gkc
Copy link
Contributor

gkc commented Oct 12, 2023

Thanks @sitaram-kalluri

@sitaram-kalluri
Copy link
Member

Attaching the screenshots of the the demo app developed for enrollment service

Screenshots of the demo enrollment service

home_page_1
home_screen
receive_enrollment_request
send_enrollment_screen

@ksanty
Copy link
Member

ksanty commented Dec 11, 2023

@sachins-geekyants @Sardar1208 tasks to be defined for the apps team. @murali-shris will clarify further

@Sardar1208
Copy link

@sachins-geekyants Has completed the the UI according to the design. Currently working on the integration of services.
Minor blocker due to unsupported feature on iOS

@Sardar1208
Copy link

Reducing to 6 SP and moving to next sprint

@Sardar1208
Copy link

Needs more work. Keeping the 6SP and moving to next sprint

@Sardar1208
Copy link

Needs more work
moving to next sprint.

@sachins-geekyants
Copy link

apkam keychain store migrated from flutter_secure_storage to biometric_storage : apkam_onboarding_biometric_storage

@sachins-geekyants
Copy link

Currently, we have two dependencies on sdk

cc: @sitaram-kalluri

@sitaram-kalluri
Copy link
Member

sitaram-kalluri commented Mar 4, 2024

Currently, we have two dependencies on sdk

* [encryptedAPKAMSymmetric key is missed when the pending enrollments are fetched](https://github.com/atsign-foundation/at_server/issues/1821)

* on enrollment approval, there is no way of knowing the path where atKey have been saved

cc: @sitaram-kalluri

encryptedAPKAMSymmetric key is missed when the pending enrollments are fetched : This is completed and changes are deployed to canary.

We are working on 2nd issue.

@gkc
Copy link
Contributor

gkc commented Mar 4, 2024

@sitaram-kalluri Have you done sanity testing with any of the canary atSigns? If it's safe to promote this from canary to prod then we should do that without much delay.

@sitaram-kalluri
Copy link
Member

@sitaram-kalluri Have you done sanity testing with any of the canary atSigns? If it's safe to promote this from canary to prod then we should do that without much delay.

@gkc : Purnima is running sanity tests on the canary atSigns.

@sitaram-kalluri
Copy link
Member

Currently, we have two dependencies on sdk

* [encryptedAPKAMSymmetric key is missed when the pending enrollments are fetched](https://github.com/atsign-foundation/at_server/issues/1821)

* on enrollment approval, there is no way of knowing the path where atKey have been saved

cc: @sitaram-kalluri

The second issue is addressed in the PR: atsign-foundation/at_client_sdk#1257

@sachins-geekyants
Copy link

We have a working version of enrollment package.

Work that still needs to be done

- fetchPendingEnrollments gives denied/approved requests.
- use the generated atkey to automatically onboard
- docs

@sitaram-kalluri
Copy link
Member

We have a working version of enrollment demo app which is available in the following branch: https://github.com/atsign-foundation/at_widgets/tree/enrollment_screens .

Pending work is to merge the changes into trunk branch and publish the packages. We have a tracker ticket on the pending action items: https://github.com/atsign-foundation/operations/issues/88

Closing this ticket here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants