You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rework the AtCommitLog and CommitLogKeyStore to segregate client and server-specific functionalities.
Within commit_log_keystore.dart, introduce a new abstract class named "BaseCommitLogKeyStore." This class should implement HiveBase and contain methods that are common between the client and server. Subsequently, transform the CommitLogKeyStore to extend "BaseCommitLogKeyStore" instead of implementing HiveBase, now containing server-specific methods. Simultaneously, introduce a new class called "ClientCommitLogKeyStore," extending "CommitLogKeyStore," to house client-specific methods.
Design and code changes
Unit and functional test
Raise PR
Address PR review comments
Merge and publish the changes
The text was updated successfully, but these errors were encountered:
Re-tested the changes, Previously reported issues are fixed. Comparison between the time taken for sync with trunk and this branch
The observation is sync is taking considerably longer time as the commits increase. For example
For just 1000 commits, The Initial sync takes 6 seconds to complete
For 10000 commits, the time to sync for the first 1000 keys is 1 minute 45 seconds
For 30000 commits, the time to sync for the first 1000 keys is around 3 minutes
trunk branch
1)For just 1000 commits, The Initial sync takes 7 seconds
2) For 10000 commits, the time taken for the first 1000 keys is 7 seconds
3) For 30000 commits, the time taken for the first 1000 keys is 7 seconds
Rework the AtCommitLog and CommitLogKeyStore to segregate client and server-specific functionalities.
Within commit_log_keystore.dart, introduce a new abstract class named "BaseCommitLogKeyStore." This class should implement HiveBase and contain methods that are common between the client and server. Subsequently, transform the CommitLogKeyStore to extend "BaseCommitLogKeyStore" instead of implementing HiveBase, now containing server-specific methods. Simultaneously, introduce a new class called "ClientCommitLogKeyStore," extending "CommitLogKeyStore," to house client-specific methods.
The text was updated successfully, but these errors were encountered: