Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End2end tests that pass without being able to reach another atServer #1593

Closed
cpswan opened this issue Oct 4, 2023 · 2 comments
Closed

End2end tests that pass without being able to reach another atServer #1593

cpswan opened this issue Oct 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cpswan
Copy link
Member

cpswan commented Oct 4, 2023

Describe the bug

35 tests passed, 31 failed. when cicd3 couldn't connect to cicd4 (and similarly cicd5 & 6)

Steps to reproduce

  1. First I configure cicd atServers to connect to wrong atDirectory
  2. Then I run end2end tests
  3. And then many of them pass even though remote atServers are unreachable

https://github.com/atsign-foundation/at_server/actions/runs/6402399843/job/17385865736 provides an example

Expected behavior

End2end tests should only pass when another atServer is involved.

Tests that don't need another atServer should be refactored into functional tests.

If the run time for functional tests gets too long we can break them into batches.

Additional context

This happened whilst migrating the cicd atServers, and a bunch of them were pointed at the wrong root server and thus unable to connect to their opposite atServer
at_server_logs_6651.zip

@cpswan cpswan added the bug Something isn't working label Oct 4, 2023
@purnimavenkatasubbu
Copy link
Member

Refactored the tests and raised PR

@cpswan
Copy link
Member Author

cpswan commented Oct 20, 2023

Nice work @purnimavenkatasubbu it's good to see that the functional tests still run in a reasonable time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants