Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] Enable a dormant feature - optimize commits for expired keys #1728

Open
srieteja opened this issue Jan 4, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@srieteja
Copy link
Contributor

srieteja commented Jan 4, 2024

Is your feature request related to a problem? Please describe.

Feature in #1660 has been implemented in #1713 and #1727. To preserve backwards compatibility, this feature will lie dormant for now. As a response to the changes in at_server, some changes have been made in at_client in atsign-foundation/at_client_sdk#1187.

Describe the solution you'd like

Enable the dormant feature at an appropriate time. The only change required would be to change the value of the variable in AtSecondaryConfig named '_optimizeCommitLog' and set it to true.

@srieteja srieteja added the enhancement New feature or request label Jan 4, 2024
@srieteja srieteja self-assigned this Jan 4, 2024
@srieteja srieteja changed the title Enable a dormant feature - optimize commits for expired keys [Tracker] Enable a dormant feature - optimize commits for expired keys Jan 22, 2024
@srieteja
Copy link
Contributor Author

srieteja commented Jul 8, 2024

Discovered a minor issue in the client side deleteExpiredKeys scheduled job. More in atsign-foundation/at_client_sdk#1350. Carrying it forward to PR92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant