Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to prevent an app from *accidentally* removing its own enrollment #1926

Closed
gkc opened this issue Apr 28, 2024 · 2 comments · Fixed by #1933
Closed

Need a way to prevent an app from *accidentally* removing its own enrollment #1926

gkc opened this issue Apr 28, 2024 · 2 comments · Fixed by #1933
Assignees
Labels
enhancement New feature or request

Comments

@gkc
Copy link
Contributor

gkc commented Apr 28, 2024

Is your feature request related to a problem? Please describe.

Possibility that a user, managing enrollments, accidentally revokes their current enrollment. This would be super annoying and difficult, perhaps impossible to recover from.

Describe the solution you'd like

  • enroll:revoke throws an exception if the enrollment being revoked is the current connection's enrollment
  • add an extra parameter to allow the user (or app) to make the revoke request with some sort of "yes I know what I'm doing" flag e.g. 'force' or 'revokeself'
  • this flag could be added to EnrollParams
  • or we could modify the enroll verb syntax to allow enroll:revoke:revokeself:$enrollParamsJson or enroll:revoke:force:$enrollParamsJson

Describe alternatives you've considered

No response

Additional context

No response

@murali-shris
Copy link
Member

murali-shris commented Apr 30, 2024

@gkc

  1. if enrollment being revoked is current connection enrollment
    1.1 enroll:revoke:{"enrollmentId":"123"} - throw Exception
    1.2 enroll:revoke:force:{"enrollmentId":"123"} - revoke the enrollment
  2. if enrollment being revoked is some other client enrollment
    2.1 enroll:revoke:{"enrollmentId":"123"} - revoke the enrollment
    2.2 enroll:revoke:force:{"enrollmentId":"123"} - revoke the enrollment

Are these scenarios correct?

@gkc
Copy link
Contributor Author

gkc commented Apr 30, 2024

Yes they are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants