Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for apkam authorization for sub namespaces #2030

Closed
murali-shris opened this issue Jul 18, 2024 · 4 comments
Closed

add tests for apkam authorization for sub namespaces #2030

murali-shris opened this issue Jul 18, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

Is your feature request related to a problem? Please describe.

Is an apkam enrollment has access to a namespace, then it should be able to access sub namespaces
e.g
if enrollment has access to .buzz, then .contacts.buzz, .notifications.buzz should be allowed

Describe the solution you'd like

write tests to validate the authorization check for sub namespaces

Describe alternatives you've considered

No response

Additional context

No response

@murali-shris murali-shris added the enhancement New feature or request label Jul 18, 2024
@murali-shris murali-shris self-assigned this Jul 18, 2024
@murali-shris
Copy link
Member Author

murali-shris commented Jul 18, 2024

@gkc @sitaram-kalluri
subnamespace authorization currently works because of this behavior

update:phone.contacts.buzz@alice 1234

In AtKey implementation, phone.contacts is treated as key and buzz as the namespace

in the above scenarion AtKey.fromString('phone.contacts.buzz@ alice').namespace should return buzz or contacts.buzz ?

@gkc
Copy link
Contributor

gkc commented Jul 22, 2024

It should continue to return buzz.

@purnimavenkatasubbu
Copy link
Member

Tests has been added in the following branch

@murali-shris
Copy link
Member Author

#2051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants