Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pkam verb handler accepts SHA512 as a valid hashing algorithm #2045

Closed
srieteja opened this issue Jul 30, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@srieteja
Copy link
Contributor

srieteja commented Jul 30, 2024

Describe the bug

Although AtChops has logic to sign and verify data using SHA512, PKAM verb does not recognize SHA512 as a valid hashing algo. After debugging, turns out that this is due to the regex explicitly accepting only SHA256.

Steps to reproduce

  1. Create an OnboardingCli instance with hashing algo set to SHA512 in AtOnboardingPreference and other required preferences set
  2. Call onboardingService.authenticate()
  3. This will trigger a format exception

Expected behavior

Signing and verification should be performed seamlessly when using SHA256 or SHA512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant