Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When skipCommitsForExpiredKeys is enabled, original commit entries for each of the keys might be getting left behind #2071

Closed
srieteja opened this issue Aug 25, 2024 · 1 comment · Fixed by #2076
Assignees
Labels
bug Something isn't working

Comments

@srieteja
Copy link
Contributor

srieteja commented Aug 25, 2024

Describe the bug

skipCommitsForExpiredKeys has been implemented (#1660), which skips writing commit entries when deleting expired keys. When enabled, the original commit entry created while creating the key might be left behind.

Previously, when an expired key was deleted the latest commitEntry for that key would be updated to DELETE which is valid. But with this change, the latest commitEntry would indicate CommitOp.UPDATE but the key actually has been deleted.

Expected behaviour

The commitLog should contain accurate and up-to-date details for the status of each key in the Keystore

Possible solutions

  • Delete all commitEntries for an expired key when it's being removed from the Keystore.

Additional context

@srieteja
Copy link
Contributor Author

srieteja commented Sep 3, 2024

Manual testing is being done for this implementation in the linked PR. Carrying it forward to PR95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants