Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK4 (gnome 40) support #10

Open
Gouster4 opened this issue Apr 2, 2021 · 12 comments
Open

GTK4 (gnome 40) support #10

Gouster4 opened this issue Apr 2, 2021 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@Gouster4
Copy link

Gouster4 commented Apr 2, 2021

Hi. I know gnome 40 is still in alfa stage, but it would be cool if you can adopt this extension.

@nilathedragon
Copy link

Generally its working pretty well on gnome 40. Major Issue I am seeing with gnome 40 is that when you open the overview/mission control (Where you see all workspaces + the dock) and close it again, the top bar will be black regardless of whether there is a window near or not.

Once you interact with a window, it snaps back to the correct state though.

@aunetx
Copy link
Owner

aunetx commented Apr 13, 2021

I will see what I can do! If there are other issues regarding gnome 40, feel free to put them here (so I can fix them when I have the time) :)

@aunetx aunetx self-assigned this Apr 13, 2021
@aunetx aunetx added the bug Something isn't working label Apr 13, 2021
@nilathedragon
Copy link

I found that this error occurs when I try to open the extension settings

Gtk.BuilderError: /home/nila/.local/share/gnome-shell/extensions/fully-transparent-top-bar@aunetx/prefs.ui:24:40 Invalid property: GtkBox.border_width

Stack trace:
  _init@/home/nila/.local/share/gnome-shell/extensions/fully-transparent-top-bar@aunetx/prefs.js:29:17
  wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:83:27
  buildPrefsWidget@/home/nila/.local/share/gnome-shell/extensions/fully-transparent-top-bar@aunetx/prefs.js:14:18
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:209:40
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

@aunetx
Copy link
Owner

aunetx commented Apr 18, 2021

Thanks for the info, the settings are still not ported to GTK4... Although this will be relatively easy, but I need first to port the rest of the extension I guess!

@Froggy232
Copy link

Hi,
Thanks you a lot for your extension!
Do you have any news on the gtk4/gnome 40 version?
Thanks you!

@Froggy232
Copy link

Hi,
I just got a new laptop, and I would love to know where to get the config files of the extension on my desktop?
My laptop and my desktop are configured the same way, and the smart transparent topbar settings are the last thing I need to do.
Thanks a lot!

@aunetx
Copy link
Owner

aunetx commented Jul 30, 2021

I'm sorry for the delay @Froggy232... the settings can be configured from gsettings, or a GUI (for example dconf), but I don't know the exact path, probably something like org.gnome.shell.extensions.smart-transparent-topbar or something like that

TBH I don't plan to update this extension for gnome 40, as alternatives exist and I focus mainly on support Blur my Shell... But BmS will soon have a way to mimic this extension's behaviour

@nilathedragon
Copy link

I'm sorry for the delay @Froggy232... the settings can be configured from gsettings, or a GUI (for example dconf), but I don't know the exact path, probably something like org.gnome.shell.extensions.smart-transparent-topbar or something like that

TBH I don't plan to update this extension for gnome 40, as alternatives exist and I focus mainly on support Blur my Shell... But BmS will soon have a way to mimic this extension's behaviour

BmS being able to mimic this will work fine for me ^^ Maybe put a deprecation notice in the readme so others will know to use BmS instead

@aunetx
Copy link
Owner

aunetx commented Jul 30, 2021

Yeah, good idea!
TBH implementing this in BmS will not be done today, but I can try to finish it in a week or too! And OFC, will notice you when this is done :)

@nilathedragon
Copy link

Yeah, good idea!
TBH implementing this in BmS will not be done today, but I can try to finish it in a week or too! And OFC, will notice you when this is done :)

Sounds great! Already got BmS and I was kinda expecting this transition to happen :D they go well together. Both great extensions!

@aunetx
Copy link
Owner

aunetx commented Jul 30, 2021

I added the notice :)

Thanks a lot! To be honest I have not a lot of merit for Smart Transparent Topbar, I just did a fork and tried to play with it... But BmS is better at least :p

@Froggy232
Copy link

Froggy232 commented Aug 5, 2021

Thanks you a lot, implemented in BMS is perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants