Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate higher memory usage after switching to OpenAPI for SMP metadata #322

Open
ecordell opened this issue Jul 11, 2024 · 0 comments

Comments

@ecordell
Copy link
Contributor

#320 switched from using a fork of client-go with SMP metadata included on the ApplyConfiguration types to pulling the OpenAPI schema and using that to for structured merge patch metadata. That PR also updated kube deps to 1.30.2.

One (or both) of those changes resulted in significantly higher memory usage - in a stage environment, the steady state went from ~25MB to ~90MB. Looking at profiles, the majority of the memory is held by the OpenAPI kube machinery.

Long term this issue might go away - we don't actually want to be using Structured Merge Patch, it would be much nicer to send multiple FieldManagers in the same API request to support the patches feature, but in the meantime it's worth seeing if there's a way to reduce the footprint.

ecordell added a commit that referenced this issue Jul 15, 2024
After #320, memory usage increased quite a bit. While still usually within the limits already set, this commit bumps the defaults a bit to provide similar headroom to the previous defaults.

#322 tracks finding the root cause (the openapi change or the kube dependency updates), after which we can lower these defaults down again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant