From 995ba8883868cbf2f009199fc4dd6ffb08d5f35e Mon Sep 17 00:00:00 2001 From: Rodrigo Queiro Date: Tue, 5 Nov 2024 16:08:01 +0000 Subject: [PATCH 1/2] Use complete sentence in error --- pkg/development/validation.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/development/validation.go b/pkg/development/validation.go index 99a4ff3fa2..b3da6cf2de 100644 --- a/pkg/development/validation.go +++ b/pkg/development/validation.go @@ -212,7 +212,7 @@ func validateSubjects(onrKey blocks.ObjectRelation, fs developmentmembership.Fou log.Err(err).Msg("could not cast columnPosition to uint32") } failures = append(failures, &devinterface.DeveloperError{ - Message: fmt.Sprintf("For object and permission/relation `%s`, subject `%s` found but missing from specified", + Message: fmt.Sprintf("For object and permission/relation `%s`, subject `%s` found but not listed in expected subjects", tuple.StringONR(onr), tuple.StringONR(foundSubject.Subject()), ), From dd8a214473496e5841db047926238f5512b00d2f Mon Sep 17 00:00:00 2001 From: Rodrigo Queiro Date: Tue, 5 Nov 2024 16:38:45 +0000 Subject: [PATCH 2/2] Update operations_test.go --- pkg/development/wasm/operations_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/development/wasm/operations_test.go b/pkg/development/wasm/operations_test.go index 49e0bc4b44..a3dd92cf23 100644 --- a/pkg/development/wasm/operations_test.go +++ b/pkg/development/wasm/operations_test.go @@ -700,7 +700,7 @@ assertFalse: garbage `assertTrue: - document:somedoc#view@user:jimmy`, &devinterface.DeveloperError{ - Message: "For object and permission/relation `document:somedoc#view`, subject `user:jimmy` found but missing from specified", + Message: "For object and permission/relation `document:somedoc#view`, subject `user:jimmy` found but not listed in expected subjects", Kind: devinterface.DeveloperError_EXTRA_RELATIONSHIP_FOUND, Source: devinterface.DeveloperError_VALIDATION_YAML, Context: "document:somedoc#view",