Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nos server __service "DeleteFile" is using wrong keyword when deleting files uploaded with relative path. #523

Open
jiexiong2016 opened this issue Jan 17, 2024 · 0 comments
Open

nos server __service "DeleteFile" is using wrong keyword when deleting files uploaded with relative path. #523

jiexiong2016 opened this issue Jan 17, 2024 · 0 comments
Assignees
@jiexiong2016
Labels
bug Something isn't working

Comments

@jiexiong2016
Copy link

jiexiong2016 commented Jan 17, 2024 •
edited
Loading

The automatic delete after upload seems not working when using relative path.
@jiexiong2016 jiexiong2016 self-assigned this Jan 17, 2024
@jiexiong2016 jiexiong2016 added the bug Something isn't working label Jan 17, 2024
@jiexiong2016 jiexiong2016 mentioned this issue Jan 17, 2024
Merged
4 tasks
@jiexiong2016 jiexiong2016 changed the title nos server __service "DeleteFile" is using wrong keyword when deleting files uploaded to modes served by "nos serve up". nos server __service "DeleteFile" is using wrong keyword when deleting files uploaded with relative path. Jan 19, 2024
jiexiong2016 pushed a commit that referenced this issue Jan 29, 2024
Update upload file to convert absolute path of given file. (#524)
2329af3 
Fix issue #523

<!-- Thank you for your contribution! Please review
https://github.com/autonomi-ai/nos/blob/main/docs/CONTRIBUTING.md before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Summary

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issues

<!-- For example: "Closes #1234" -->

## Checks

- [x] `make lint`: I've run `make lint` to lint the changes in this PR.
- [ ] `make test`: I've made sure the tests (`make test-cpu` or `make
test`) are passing.
- Additional tests:
   - [ ] Benchmark tests (when contributing new models)
   - [ ] GPU/HW tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiexiong2016 jiexiong2016

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiexiong2016